Pass absolute path to directoryExists

amcasey · amcasey · commit ba70c536cd7c · 2021-09-27T09:22:54.000-07:00
As pointed out by @gretzkiy, the `directoryExists` call added to `matchFiles` in #44710 should have been passing the absolute path (since the current directory might not match `currentDirectory`).
diff --git a/src/compiler/utilities.ts b/src/compiler/utilities.ts
@@ -6634,8 +6634,9 @@ namespace ts {
         const visited = new Map<string, true>();
         const toCanonical = createGetCanonicalFileName(useCaseSensitiveFileNames);
         for (const basePath of patterns.basePaths) {
-            if (directoryExists(basePath)) {
-                visitDirectory(basePath, combinePaths(currentDirectory, basePath), depth);
+            const absoluteBasePath = combinePaths(currentDirectory, basePath);
+            if (directoryExists(absoluteBasePath)) {
+                visitDirectory(basePath, absoluteBasePath, depth);
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -6634,8 +6634,9 @@ namespace ts {`
`6634`	`6634`	`const visited = new Map<string, true>();`
`6635`	`6635`	`const toCanonical = createGetCanonicalFileName(useCaseSensitiveFileNames);`
`6636`	`6636`	`for (const basePath of patterns.basePaths) {`
`6637`		`- if (directoryExists(basePath)) {`
`6638`		`- visitDirectory(basePath, combinePaths(currentDirectory, basePath), depth);`
	`6637`	`+ const absoluteBasePath = combinePaths(currentDirectory, basePath);`
	`6638`	`+ if (directoryExists(absoluteBasePath)) {`
	`6639`	`+ visitDirectory(basePath, absoluteBasePath, depth);`
`6639`	`6640`	`}`
`6640`	`6641`	`}`
`6641`	`6642`