Add missing index.ts files to user projects

sandersn · sandersn · commit b3366d7730f9 · 2020-06-19T09:20:56.000-07:00
This makes the language service treat .js files inside node_modules as
part of the parent project, so that you can view the same errors in the
editor as you see in the baselines.

Also update a comment in the parser that I missed in an earlier PR.
diff --git a/src/compiler/parser.ts b/src/compiler/parser.ts
@@ -3355,7 +3355,7 @@ namespace ts {
                         type = finishNode(factory.createJSDocNonNullableType(type), pos);
                         break;
                     case SyntaxKind.QuestionToken:
-                        // If not in JSDoc and next token is start of a type we have a conditional type
+                        // If next token is start of a type we have a conditional type
                         if (lookAhead(nextTokenIsStartOfType)) {
                             return type;
                         }
diff --git a/tests/cases/user/acorn/index.ts b/tests/cases/user/acorn/index.ts
@@ -0,0 +1 @@
+import x = require('acorn');
diff --git a/tests/cases/user/acorn/tsconfig.json b/tests/cases/user/acorn/tsconfig.json
@@ -7,8 +7,16 @@
         "noEmit": true,
         "allowJs": true,
         "checkJs": true,
-        "types": ["node"],
-        "lib": ["esnext", "dom"],
+        "types": [
+            "node"
+        ],
+        "lib": [
+            "esnext",
+            "dom"
+        ]
     },
-    "include": ["node_modules/acorn"]
-}
+    "include": [
+        "node_modules/acorn",
+        "index.ts"
+    ]
+}
diff --git a/tests/cases/user/adonis-framework/index.ts b/tests/cases/user/adonis-framework/index.ts
@@ -0,0 +1 @@
+import x = require('adonis-framework/src/View');
diff --git a/tests/cases/user/adonis-framework/tsconfig.json b/tests/cases/user/adonis-framework/tsconfig.json
@@ -7,8 +7,16 @@
         "noEmit": true,
         "allowJs": true,
         "checkJs": true,
-        "types": ["node"],
-        "lib": ["esnext", "dom"],
+        "types": [
+            "node"
+        ],
+        "lib": [
+            "esnext",
+            "dom"
+        ]
     },
-    "include": ["node_modules/adonis-framework"]
-}
+    "include": [
+        "node_modules/adonis-framework",
+        "index.ts"
+    ]
+}
diff --git a/tests/cases/user/assert/index.ts b/tests/cases/user/assert/index.ts
@@ -0,0 +1 @@
+import x = require('assert');
diff --git a/tests/cases/user/assert/tsconfig.json b/tests/cases/user/assert/tsconfig.json
@@ -7,8 +7,16 @@
         "noEmit": true,
         "allowJs": true,
         "checkJs": true,
-        "types": ["node"],
-        "lib": ["esnext", "dom"],
+        "types": [
+            "node"
+        ],
+        "lib": [
+            "esnext",
+            "dom"
+        ]
     },
-    "include": ["node_modules/assert"]
-}
+    "include": [
+        "node_modules/assert",
+        "index.ts"
+    ]
+}
diff --git a/tests/cases/user/async/index.ts b/tests/cases/user/async/index.ts
@@ -0,0 +1 @@
+import async_ = require('async');
diff --git a/tests/cases/user/async/tsconfig.json b/tests/cases/user/async/tsconfig.json
@@ -10,5 +10,5 @@
         "types": ["node"],
         "lib": ["esnext", "dom"],
     },
-    "include": ["node_modules/async"]
+    "include": ["index.ts", "node_modules/async"]
 }
diff --git a/tests/cases/user/bcryptjs/index.ts b/tests/cases/user/bcryptjs/index.ts
@@ -0,0 +1 @@
+import x = require('bcryptjs');
diff --git a/tests/cases/user/bcryptjs/tsconfig.json b/tests/cases/user/bcryptjs/tsconfig.json
@@ -7,12 +7,18 @@
         "noEmit": true,
         "allowJs": true,
         "checkJs": true,
-        "types": ["node"],
-        "lib": ["esnext", "dom"],
+        "types": [
+            "node"
+        ],
+        "lib": [
+            "esnext",
+            "dom"
+        ]
     },
     "include": [
         "node_modules/bcryptjs/scripts",
         "node_modules/bcryptjs/src",
-        "node_modules/bcryptjs/tests"
+        "node_modules/bcryptjs/tests",
+        "index.ts"
     ]
-}
+}
diff --git a/tests/cases/user/bluebird/index.ts b/tests/cases/user/bluebird/index.ts
@@ -0,0 +1 @@
+import x = require('bluebird');
diff --git a/tests/cases/user/bluebird/tsconfig.json b/tests/cases/user/bluebird/tsconfig.json
@@ -7,8 +7,16 @@
         "noEmit": true,
         "allowJs": true,
         "checkJs": true,
-        "types": ["node"],
-        "lib": ["esnext", "dom"],
+        "types": [
+            "node"
+        ],
+        "lib": [
+            "esnext",
+            "dom"
+        ]
     },
-    "include": ["node_modules/bluebird/js/release"]
-}
+    "include": [
+        "node_modules/bluebird/js/release",
+        "index.ts"
+    ]
+}
diff --git a/tests/cases/user/clear-require/index.ts b/tests/cases/user/clear-require/index.ts
@@ -0,0 +1 @@
+import x = require('clear-require');
diff --git a/tests/cases/user/clear-require/tsconfig.json b/tests/cases/user/clear-require/tsconfig.json
@@ -7,8 +7,16 @@
         "noEmit": true,
         "allowJs": true,
         "checkJs": true,
-        "lib": ["esnext", "dom"],
-        "types": ["node"]
+        "lib": [
+            "esnext",
+            "dom"
+        ],
+        "types": [
+            "node"
+        ]
     },
-    "include": ["node_modules/clear-require"]
-}
+    "include": [
+        "node_modules/clear-require",
+        "index.ts"
+    ]
+}
diff --git a/tests/cases/user/clone/index.ts b/tests/cases/user/clone/index.ts
@@ -0,0 +1 @@
+import x = require('clone');
diff --git a/tests/cases/user/clone/tsconfig.json b/tests/cases/user/clone/tsconfig.json
@@ -7,8 +7,16 @@
         "noEmit": true,
         "allowJs": true,
         "checkJs": true,
-        "types": ["node"],
-        "lib": ["esnext", "dom"],
+        "types": [
+            "node"
+        ],
+        "lib": [
+            "esnext",
+            "dom"
+        ]
     },
-    "include": ["node_modules/clone"]
-}
+    "include": [
+        "node_modules/clone",
+        "index.ts"
+    ]
+}
diff --git a/tests/cases/user/content-disposition/index.ts b/tests/cases/user/content-disposition/index.ts
@@ -0,0 +1 @@
+import x = require('content-disposition');
diff --git a/tests/cases/user/content-disposition/tsconfig.json b/tests/cases/user/content-disposition/tsconfig.json
@@ -7,8 +7,16 @@
         "noEmit": true,
         "allowJs": true,
         "checkJs": true,
-        "types": ["node"],
-        "lib": ["esnext", "dom"],
+        "types": [
+            "node"
+        ],
+        "lib": [
+            "esnext",
+            "dom"
+        ]
     },
-    "include": ["node_modules/content-disposition"]
-}
+    "include": [
+        "node_modules/content-disposition",
+        "index.ts"
+    ]
+}
diff --git a/tests/cases/user/debug/index.ts b/tests/cases/user/debug/index.ts
@@ -0,0 +1 @@
+import debug = require('debug');
diff --git a/tests/cases/user/debug/tsconfig.json b/tests/cases/user/debug/tsconfig.json
@@ -10,5 +10,5 @@
         "types": ["node"],
         "lib": ["esnext", "dom"],
     },
-    "include": ["node_modules/debug"]
+    "include": ["index.ts", "node_modules/debug"]
 }
diff --git a/tests/cases/user/enhanced-resolve/index.ts b/tests/cases/user/enhanced-resolve/index.ts
@@ -0,0 +1 @@
+import x = require('enhanced-resolve');
diff --git a/tests/cases/user/enhanced-resolve/tsconfig.json b/tests/cases/user/enhanced-resolve/tsconfig.json
@@ -7,10 +7,18 @@
         "noEmit": true,
         "allowJs": true,
         "checkJs": true,
-        "types": ["node"],
-        "lib": ["esnext", "dom"],
+        "types": [
+            "node"
+        ],
+        "lib": [
+            "esnext",
+            "dom"
+        ],
         "module": "CommonJS",
-        "target": "esnext",
+        "target": "esnext"
     },
-    "include": ["node_modules/enhanced-resolve"]
-}
+    "include": [
+        "node_modules/enhanced-resolve",
+        "index.ts"
+    ]
+}
diff --git a/tests/cases/user/follow-redirects/index.ts b/tests/cases/user/follow-redirects/index.ts
@@ -0,0 +1 @@
+import x = require('follow-redirects');
diff --git a/tests/cases/user/follow-redirects/tsconfig.json b/tests/cases/user/follow-redirects/tsconfig.json
@@ -7,8 +7,16 @@
         "noEmit": true,
         "allowJs": true,
         "checkJs": true,
-        "types": ["node"],
-        "lib": ["esnext", "dom"],
+        "types": [
+            "node"
+        ],
+        "lib": [
+            "esnext",
+            "dom"
+        ]
     },
-    "include": ["node_modules/follow-redirects"]
-}
+    "include": [
+        "node_modules/follow-redirects",
+        "index.ts"
+    ]
+}
diff --git a/tests/cases/user/graceful-fs/index.ts b/tests/cases/user/graceful-fs/index.ts
@@ -0,0 +1 @@
+import x = require('graceful-fs');
diff --git a/tests/cases/user/graceful-fs/tsconfig.json b/tests/cases/user/graceful-fs/tsconfig.json
@@ -7,8 +7,16 @@
         "noEmit": true,
         "allowJs": true,
         "checkJs": true,
-        "types": ["node"],
-        "lib": ["esnext", "dom"],
+        "types": [
+            "node"
+        ],
+        "lib": [
+            "esnext",
+            "dom"
+        ]
     },
-    "include": ["node_modules/graceful-fs"]
-}
+    "include": [
+        "node_modules/graceful-fs",
+        "index.ts"
+    ]
+}
diff --git a/tests/cases/user/lodash/index.ts b/tests/cases/user/lodash/index.ts
@@ -0,0 +1 @@
+import x = require('lodash');
diff --git a/tests/cases/user/lodash/tsconfig.json b/tests/cases/user/lodash/tsconfig.json
@@ -7,9 +7,19 @@
         "noEmit": true,
         "allowJs": true,
         "checkJs": true,
-        "types": ["node"],
-        "lib": ["esnext", "dom"],
+        "types": [
+            "node"
+        ],
+        "lib": [
+            "esnext",
+            "dom"
+        ]
     },
-    "include": ["node_modules/lodash"],
-    "exclude": ["node_modules/lodash/lodash.js"]
-}
+    "include": [
+        "node_modules/lodash",
+        "index.ts"
+    ],
+    "exclude": [
+        "node_modules/lodash/lodash.js"
+    ]
+}
diff --git a/tests/cases/user/minimatch/index.ts b/tests/cases/user/minimatch/index.ts
@@ -0,0 +1 @@
+import x = require('minimatch');
diff --git a/tests/cases/user/minimatch/tsconfig.json b/tests/cases/user/minimatch/tsconfig.json
@@ -7,8 +7,16 @@
         "noEmit": true,
         "allowJs": true,
         "checkJs": true,
-        "types": ["node"],
-        "lib": ["esnext", "dom"],
+        "types": [
+            "node"
+        ],
+        "lib": [
+            "esnext",
+            "dom"
+        ]
     },
-    "include": ["node_modules/minimatch"]
-}
+    "include": [
+        "node_modules/minimatch",
+        "index.ts"
+    ]
+}
diff --git a/tests/cases/user/npm/index.ts b/tests/cases/user/npm/index.ts
@@ -0,0 +1 @@
+import x = require('npm');
diff --git a/tests/cases/user/npm/tsconfig.json b/tests/cases/user/npm/tsconfig.json
@@ -7,8 +7,17 @@
         "noEmit": true,
         "allowJs": true,
         "checkJs": true,
-        "types": ["node"],
-        "lib": ["esnext", "dom", "scripthost"],
+        "types": [
+            "node"
+        ],
+        "lib": [
+            "esnext",
+            "dom",
+            "scripthost"
+        ]
     },
-    "include": ["node_modules/npm"]
-}
+    "include": [
+        "node_modules/npm",
+        "index.ts"
+    ]
+}
diff --git a/tests/cases/user/npmlog/index.ts b/tests/cases/user/npmlog/index.ts
@@ -0,0 +1 @@
+import x = require('npmlog');
diff --git a/tests/cases/user/npmlog/tsconfig.json b/tests/cases/user/npmlog/tsconfig.json
diff --git a/tests/cases/user/uglify-js/index.ts b/tests/cases/user/uglify-js/index.ts
diff --git a/tests/cases/user/uglify-js/tsconfig.json b/tests/cases/user/uglify-js/tsconfig.json
diff --git a/tests/cases/user/url-search-params/index.ts b/tests/cases/user/url-search-params/index.ts
diff --git a/tests/cases/user/url-search-params/tsconfig.json b/tests/cases/user/url-search-params/tsconfig.json
diff --git a/tests/cases/user/util/index.ts b/tests/cases/user/util/index.ts
diff --git a/tests/cases/user/util/tsconfig.json b/tests/cases/user/util/tsconfig.json

Original file line number	Diff line number	Diff line change
`@@ -3355,7 +3355,7 @@ namespace ts {`
`3355`	`3355`	`type = finishNode(factory.createJSDocNonNullableType(type), pos);`
`3356`	`3356`	`break;`
`3357`	`3357`	`case SyntaxKind.QuestionToken:`
`3358`		`- // If not in JSDoc and next token is start of a type we have a conditional type`
	`3358`	`+ // If next token is start of a type we have a conditional type`
`3359`	`3359`	`if (lookAhead(nextTokenIsStartOfType)) {`
`3360`	`3360`	`return type;`
`3361`	`3361`	`}`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+import x = require('adonis-framework/src/View');`
Original file line number	Diff line number	Diff line change
`@@ -10,5 +10,5 @@`
`10`	`10`	`"types": ["node"],`
`11`	`11`	`"lib": ["esnext", "dom"],`
`12`	`12`	`},`
`13`		`- "include": ["node_modules/async"]`
	`13`	`+ "include": ["index.ts", "node_modules/async"]`
`14`	`14`	`}`