Skip to content

Commit b198eb6

Browse files
rbucktonrbuckton
committed
Remove optionality for Promise resolve callback
1 parent 03b6580 commit b198eb6

12 files changed

Lines changed: 34 additions & 34 deletions

‎src/lib/es2015.promise.d.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ interface PromiseConstructor {
1010
* a resolve callback used to resolve the promise with a value or the result of another promise,
1111
* and a reject callback used to reject the promise with a provided reason or error.
1212
*/
13-
new <T>(executor: (resolve: (value?: T | PromiseLike<T>) => void, reject: (reason?: any) => void) => void): Promise<T>;
13+
new <T>(executor: (resolve: (value: T | PromiseLike<T>) => void, reject: (reason?: any) => void) => void): Promise<T>;
1414

1515
/**
1616
* Creates a Promise that is resolved with an array of results when all of the provided Promises

‎src/lib/es5.d.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1396,7 +1396,7 @@ declare type PropertyDecorator = (target: Object, propertyKey: string | symbol)
13961396
declare type MethodDecorator = <T>(target: Object, propertyKey: string | symbol, descriptor: TypedPropertyDescriptor<T>) => TypedPropertyDescriptor<T> | void;
13971397
declare type ParameterDecorator = (target: Object, propertyKey: string | symbol, parameterIndex: number) => void;
13981398

1399-
declare type PromiseConstructorLike = new <T>(executor: (resolve: (value?: T | PromiseLike<T>) => void, reject: (reason?: any) => void) => void) => PromiseLike<T>;
1399+
declare type PromiseConstructorLike = new <T>(executor: (resolve: (value: T | PromiseLike<T>) => void, reject: (reason?: any) => void) => void) => PromiseLike<T>;
14001400

14011401
interface PromiseLike<T> {
14021402
/**

‎tests/baselines/reference/asyncAwaitNestedClasses_es5.types‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@ class A {
1414
return new Promise((resolve) => { resolve(null); });
1515
>new Promise((resolve) => { resolve(null); }) : Promise<void>
1616
>Promise : PromiseConstructor
17-
>(resolve) => { resolve(null); } : (resolve: (value?: void | PromiseLike<void>) => void) => void
18-
>resolve : (value?: void | PromiseLike<void>) => void
17+
>(resolve) => { resolve(null); } : (resolve: (value: void | PromiseLike<void>) => void) => void
18+
>resolve : (value: void | PromiseLike<void>) => void
1919
>resolve(null) : void
20-
>resolve : (value?: void | PromiseLike<void>) => void
20+
>resolve : (value: void | PromiseLike<void>) => void
2121
>null : null
2222
}
2323
static C = class C {

‎tests/baselines/reference/contextuallyTypeAsyncFunctionAwaitOperand.types‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,10 @@ async function fn1(): Promise<Obj> {
1717
>await new Promise(resolve => resolve({ key: "value" })) : Obj
1818
>new Promise(resolve => resolve({ key: "value" })) : Promise<Obj>
1919
>Promise : PromiseConstructor
20-
>resolve => resolve({ key: "value" }) : (resolve: (value?: Obj | PromiseLike<Obj>) => void) => void
21-
>resolve : (value?: Obj | PromiseLike<Obj>) => void
20+
>resolve => resolve({ key: "value" }) : (resolve: (value: Obj | PromiseLike<Obj>) => void) => void
21+
>resolve : (value: Obj | PromiseLike<Obj>) => void
2222
>resolve({ key: "value" }) : void
23-
>resolve : (value?: Obj | PromiseLike<Obj>) => void
23+
>resolve : (value: Obj | PromiseLike<Obj>) => void
2424
>{ key: "value" } : { key: "value"; }
2525
>key : "value"
2626
>"value" : "value"

‎tests/baselines/reference/contextuallyTypeAsyncFunctionReturnType.types‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,12 @@ async function fn2(): Promise<Obj> {
1717
return new Promise(resolve => {
1818
>new Promise(resolve => { resolve({ key: "value" }); }) : Promise<Obj>
1919
>Promise : PromiseConstructor
20-
>resolve => { resolve({ key: "value" }); } : (resolve: (value?: Obj | PromiseLike<Obj>) => void) => void
21-
>resolve : (value?: Obj | PromiseLike<Obj>) => void
20+
>resolve => { resolve({ key: "value" }); } : (resolve: (value: Obj | PromiseLike<Obj>) => void) => void
21+
>resolve : (value: Obj | PromiseLike<Obj>) => void
2222

2323
resolve({ key: "value" });
2424
>resolve({ key: "value" }) : void
25-
>resolve : (value?: Obj | PromiseLike<Obj>) => void
25+
>resolve : (value: Obj | PromiseLike<Obj>) => void
2626
>{ key: "value" } : { key: "value"; }
2727
>key : "value"
2828
>"value" : "value"
@@ -47,12 +47,12 @@ async function fn4(): Promise<Obj> {
4747
>await new Promise(resolve => { resolve({ key: "value" }); }) : Obj
4848
>new Promise(resolve => { resolve({ key: "value" }); }) : Promise<Obj>
4949
>Promise : PromiseConstructor
50-
>resolve => { resolve({ key: "value" }); } : (resolve: (value?: Obj | PromiseLike<Obj>) => void) => void
51-
>resolve : (value?: Obj | PromiseLike<Obj>) => void
50+
>resolve => { resolve({ key: "value" }); } : (resolve: (value: Obj | PromiseLike<Obj>) => void) => void
51+
>resolve : (value: Obj | PromiseLike<Obj>) => void
5252

5353
resolve({ key: "value" });
5454
>resolve({ key: "value" }) : void
55-
>resolve : (value?: Obj | PromiseLike<Obj>) => void
55+
>resolve : (value: Obj | PromiseLike<Obj>) => void
5656
>{ key: "value" } : { key: "value"; }
5757
>key : "value"
5858
>"value" : "value"

‎tests/baselines/reference/defaultExportInAwaitExpression01.types‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@ const x = new Promise( ( resolve, reject ) => { resolve( {} ); } );
33
>x : Promise<unknown>
44
>new Promise( ( resolve, reject ) => { resolve( {} ); } ) : Promise<unknown>
55
>Promise : PromiseConstructor
6-
>( resolve, reject ) => { resolve( {} ); } : (resolve: (value?: unknown) => void, reject: (reason?: any) => void) => void
7-
>resolve : (value?: unknown) => void
6+
>( resolve, reject ) => { resolve( {} ); } : (resolve: (value: unknown) => void, reject: (reason?: any) => void) => void
7+
>resolve : (value: unknown) => void
88
>reject : (reason?: any) => void
99
>resolve( {} ) : void
10-
>resolve : (value?: unknown) => void
10+
>resolve : (value: unknown) => void
1111
>{} : {}
1212

1313
export default x;

‎tests/baselines/reference/defaultExportInAwaitExpression02.types‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@ const x = new Promise( ( resolve, reject ) => { resolve( {} ); } );
33
>x : Promise<unknown>
44
>new Promise( ( resolve, reject ) => { resolve( {} ); } ) : Promise<unknown>
55
>Promise : PromiseConstructor
6-
>( resolve, reject ) => { resolve( {} ); } : (resolve: (value?: unknown) => void, reject: (reason?: any) => void) => void
7-
>resolve : (value?: unknown) => void
6+
>( resolve, reject ) => { resolve( {} ); } : (resolve: (value: unknown) => void, reject: (reason?: any) => void) => void
7+
>resolve : (value: unknown) => void
88
>reject : (reason?: any) => void
99
>resolve( {} ) : void
10-
>resolve : (value?: unknown) => void
10+
>resolve : (value: unknown) => void
1111
>{} : {}
1212

1313
export default x;

‎tests/baselines/reference/inferenceLimit.types‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ export class BrokenClass {
1919
>new Promise<Array<MyModule.MyModel>>((resolve, reject) => { let result: Array<MyModule.MyModel> = []; let populateItems = (order) => { return new Promise((resolve, reject) => { this.doStuff(order.id) .then((items) => { order.items = items; resolve(order); }); }); }; return Promise.all(result.map(populateItems)) .then((orders: Array<MyModule.MyModel>) => { resolve(orders); }); }) : Promise<MyModule.MyModel[]>
2020
>Promise : PromiseConstructor
2121
>MyModule : any
22-
>(resolve, reject) => { let result: Array<MyModule.MyModel> = []; let populateItems = (order) => { return new Promise((resolve, reject) => { this.doStuff(order.id) .then((items) => { order.items = items; resolve(order); }); }); }; return Promise.all(result.map(populateItems)) .then((orders: Array<MyModule.MyModel>) => { resolve(orders); }); } : (resolve: (value?: MyModule.MyModel[] | PromiseLike<MyModule.MyModel[]>) => void, reject: (reason?: any) => void) => Promise<void>
23-
>resolve : (value?: MyModule.MyModel[] | PromiseLike<MyModule.MyModel[]>) => void
22+
>(resolve, reject) => { let result: Array<MyModule.MyModel> = []; let populateItems = (order) => { return new Promise((resolve, reject) => { this.doStuff(order.id) .then((items) => { order.items = items; resolve(order); }); }); }; return Promise.all(result.map(populateItems)) .then((orders: Array<MyModule.MyModel>) => { resolve(orders); }); } : (resolve: (value: MyModule.MyModel[] | PromiseLike<MyModule.MyModel[]>) => void, reject: (reason?: any) => void) => Promise<void>
23+
>resolve : (value: MyModule.MyModel[] | PromiseLike<MyModule.MyModel[]>) => void
2424
>reject : (reason?: any) => void
2525

2626
let result: Array<MyModule.MyModel> = [];
@@ -36,8 +36,8 @@ export class BrokenClass {
3636
return new Promise((resolve, reject) => {
3737
>new Promise((resolve, reject) => { this.doStuff(order.id) .then((items) => { order.items = items; resolve(order); }); }) : Promise<unknown>
3838
>Promise : PromiseConstructor
39-
>(resolve, reject) => { this.doStuff(order.id) .then((items) => { order.items = items; resolve(order); }); } : (resolve: (value?: unknown) => void, reject: (reason?: any) => void) => void
40-
>resolve : (value?: unknown) => void
39+
>(resolve, reject) => { this.doStuff(order.id) .then((items) => { order.items = items; resolve(order); }); } : (resolve: (value: unknown) => void, reject: (reason?: any) => void) => void
40+
>resolve : (value: unknown) => void
4141
>reject : (reason?: any) => void
4242

4343
this.doStuff(order.id)
@@ -65,7 +65,7 @@ export class BrokenClass {
6565

6666
resolve(order);
6767
>resolve(order) : void
68-
>resolve : (value?: unknown) => void
68+
>resolve : (value: unknown) => void
6969
>order : any
7070

7171
});
@@ -93,7 +93,7 @@ export class BrokenClass {
9393

9494
resolve(orders);
9595
>resolve(orders) : void
96-
>resolve : (value?: MyModule.MyModel[] | PromiseLike<MyModule.MyModel[]>) => void
96+
>resolve : (value: MyModule.MyModel[] | PromiseLike<MyModule.MyModel[]>) => void
9797
>orders : MyModule.MyModel[]
9898

9999
});

‎tests/baselines/reference/modularizeLibrary_NoErrorDuplicateLibOptions1.types‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,8 +138,8 @@ async function out() {
138138
return new Promise(function (resolve, reject) {});
139139
>new Promise(function (resolve, reject) {}) : Promise<unknown>
140140
>Promise : PromiseConstructor
141-
>function (resolve, reject) {} : (resolve: (value?: unknown) => void, reject: (reason?: any) => void) => void
142-
>resolve : (value?: unknown) => void
141+
>function (resolve, reject) {} : (resolve: (value: unknown) => void, reject: (reason?: any) => void) => void
142+
>resolve : (value: unknown) => void
143143
>reject : (reason?: any) => void
144144
}
145145

‎tests/baselines/reference/modularizeLibrary_NoErrorDuplicateLibOptions2.types‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,8 +138,8 @@ async function out() {
138138
return new Promise(function (resolve, reject) {});
139139
>new Promise(function (resolve, reject) {}) : Promise<unknown>
140140
>Promise : PromiseConstructor
141-
>function (resolve, reject) {} : (resolve: (value?: unknown) => void, reject: (reason?: any) => void) => void
142-
>resolve : (value?: unknown) => void
141+
>function (resolve, reject) {} : (resolve: (value: unknown) => void, reject: (reason?: any) => void) => void
142+
>resolve : (value: unknown) => void
143143
>reject : (reason?: any) => void
144144
}
145145

0 commit comments

Comments
 (0)