Refactor wrapSymbolTrackerToReportForContext to improve perf

rbuckton · rbuckton · commit 9f8b104982f4 · 2022-12-06T14:53:07.000-05:00
diff --git a/.gitignore b/.gitignore
@@ -84,3 +84,4 @@ tests/cases/user/puppeteer/puppeteer
 tests/cases/user/axios-src/axios-src
 tests/cases/user/prettier/prettier
 .eslintcache
+*v8.log
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
diff --git a/src/compiler/types.ts b/src/compiler/types.ts
@@ -5115,7 +5115,7 @@ export interface SymbolWalker {
 
 // This was previously deprecated in our public API, but is still used internally
 /** @internal */
-export interface SymbolWriter extends SymbolTracker {
+export interface SymbolWriter {
     writeKeyword(text: string): void;
     writeOperator(text: string): void;
     writePunctuation(text: string): void;
@@ -9132,19 +9132,19 @@ export interface SymbolTracker {
     // Called when the symbol writer encounters a symbol to write.  Currently only used by the
     // declaration emitter to help determine if it should patch up the final declaration file
     // with import statements it previously saw (but chose not to emit).
-    trackSymbol?(symbol: Symbol, enclosingDeclaration: Node | undefined, meaning: SymbolFlags): boolean;
-    reportInaccessibleThisError?(): void;
-    reportPrivateInBaseOfClassExpression?(propertyName: string): void;
-    reportInaccessibleUniqueSymbolError?(): void;
-    reportCyclicStructureError?(): void;
-    reportLikelyUnsafeImportRequiredError?(specifier: string): void;
-    reportTruncationError?(): void;
+    trackSymbol?(this: SymbolTracker, symbol: Symbol, enclosingDeclaration: Node | undefined, meaning: SymbolFlags): boolean;
+    reportInaccessibleThisError?(this: SymbolTracker, ): void;
+    reportPrivateInBaseOfClassExpression?(this: SymbolTracker, propertyName: string): void;
+    reportInaccessibleUniqueSymbolError?(this: SymbolTracker, ): void;
+    reportCyclicStructureError?(this: SymbolTracker, ): void;
+    reportLikelyUnsafeImportRequiredError?(this: SymbolTracker, specifier: string): void;
+    reportTruncationError?(this: SymbolTracker, ): void;
     moduleResolverHost?: ModuleSpecifierResolutionHost & { getCommonSourceDirectory(): string };
-    trackReferencedAmbientModule?(decl: ModuleDeclaration, symbol: Symbol): void;
-    trackExternalModuleSymbolOfImportTypeNode?(symbol: Symbol): void;
-    reportNonlocalAugmentation?(containingFile: SourceFile, parentSymbol: Symbol, augmentingSymbol: Symbol): void;
-    reportNonSerializableProperty?(propertyName: string): void;
-    reportImportTypeNodeResolutionModeOverride?(): void;
+    trackReferencedAmbientModule?(this: SymbolTracker, decl: ModuleDeclaration, symbol: Symbol): void;
+    trackExternalModuleSymbolOfImportTypeNode?(this: SymbolTracker, symbol: Symbol): void;
+    reportNonlocalAugmentation?(this: SymbolTracker, containingFile: SourceFile, parentSymbol: Symbol, augmentingSymbol: Symbol): void;
+    reportNonSerializableProperty?(this: SymbolTracker, propertyName: string): void;
+    reportImportTypeNodeResolutionModeOverride?(this: SymbolTracker): void;
 }
 
 export interface TextSpan {
diff --git a/src/compiler/utilities.ts b/src/compiler/utilities.ts
@@ -600,10 +600,6 @@ function createSingleLineStringWriter(): EmitTextWriter {
         increaseIndent: noop,
         decreaseIndent: noop,
         clear: () => str = "",
-        trackSymbol: () => false,
-        reportInaccessibleThisError: noop,
-        reportInaccessibleUniqueSymbolError: noop,
-        reportPrivateInBaseOfClassExpression: noop,
     };
 }
 
@@ -5162,10 +5158,6 @@ export function createTextWriter(newLine: string): EmitTextWriter {
         hasTrailingComment: () => hasTrailingComment,
         hasTrailingWhitespace: () => !!output.length && isWhiteSpaceLike(output.charCodeAt(output.length - 1)),
         clear: reset,
-        reportInaccessibleThisError: noop,
-        reportPrivateInBaseOfClassExpression: noop,
-        reportInaccessibleUniqueSymbolError: noop,
-        trackSymbol: () => false,
         writeKeyword: write,
         writeOperator: write,
         writeParameter: write,
diff --git a/src/services/inlayHints.ts b/src/services/inlayHints.ts
@@ -387,7 +387,7 @@ export function provideInlayHints(context: InlayHintsContext): InlayHint[] {
         const printer = createPrinter(options);
 
         return usingSingleLineStringWriter(writer => {
-            const typeNode = checker.typeToTypeNode(type, /*enclosingDeclaration*/ undefined, flags, writer);
+            const typeNode = checker.typeToTypeNode(type, /*enclosingDeclaration*/ undefined, flags);
             Debug.assertIsDefined(typeNode, "should always get typenode");
             printer.writeNode(EmitHint.Unspecified, typeNode, /*sourceFile*/ file, writer);
         });
diff --git a/src/services/utilities.ts b/src/services/utilities.ts
@@ -271,7 +271,6 @@ import {
     nodeIsMissing,
     nodeIsPresent,
     nodeIsSynthesized,
-    noop,
     normalizePath,
     NoSubstitutionTemplateLiteral,
     notImplemented,
@@ -2721,10 +2720,6 @@ function getDisplayPartWriter(): DisplayPartsSymbolWriter {
         increaseIndent: () => { indent++; },
         decreaseIndent: () => { indent--; },
         clear: resetWriter,
-        trackSymbol: () => false,
-        reportInaccessibleThisError: noop,
-        reportInaccessibleUniqueSymbolError: noop,
-        reportPrivateInBaseOfClassExpression: noop,
     };
 
     function writeIndent() {
