Error on new type-ish names named undefined

jakebailey · jakebailey · commit 7e0ddf40e693 · 2024-02-28T09:02:50.000-08:00
diff --git a/src/compiler/parser.ts b/src/compiler/parser.ts
@@ -3923,6 +3923,9 @@ namespace Parser {
         const pos = getNodePos();
         const modifiers = parseModifiers(/*allowDecorators*/ false, /*permitConstAsModifier*/ true);
         const name = parseIdentifier();
+        if (name.escapedText === "undefined") {
+            parseErrorAtRange(name, Diagnostics.Type_parameter_name_cannot_be_0, "undefined");
+        }
         let constraint: TypeNode | undefined;
         let expression: Expression | undefined;
         if (parseOptional(SyntaxKind.ExtendsKeyword)) {
@@ -4369,6 +4372,9 @@ namespace Parser {
     function parseMappedTypeParameter() {
         const pos = getNodePos();
         const name = parseIdentifierName();
+        if (name.escapedText === "undefined") {
+            parseErrorAtRange(name, Diagnostics.Declaration_name_conflicts_with_built_in_global_identifier_0, "undefined");
+        }
         parseExpected(SyntaxKind.InKeyword);
         const type = parseType();
         return finishNode(factory.createTypeParameterDeclaration(/*modifiers*/ undefined, name, type, /*defaultType*/ undefined), pos);
@@ -4733,6 +4739,9 @@ namespace Parser {
     function parseTypeParameterOfInferType(): TypeParameterDeclaration {
         const pos = getNodePos();
         const name = parseIdentifier();
+        if (name.escapedText === "undefined") {
+            parseErrorAtRange(name, Diagnostics.Declaration_name_conflicts_with_built_in_global_identifier_0, "undefined");
+        }
         const constraint = tryParse(tryParseConstraintOfInferType);
         const node = factory.createTypeParameterDeclaration(/*modifiers*/ undefined, name, constraint);
         return finishNode(node, pos);
@@ -8097,6 +8106,9 @@ namespace Parser {
 
         // We don't parse the name here in await context, instead we will report a grammar error in the checker.
         const name = parseNameOfClassDeclarationOrExpression();
+        if (name?.escapedText === "undefined") {
+            parseErrorAtRange(name, Diagnostics.Declaration_name_conflicts_with_built_in_global_identifier_0, "undefined");
+        }
         const typeParameters = parseTypeParameters();
         if (some(modifiers, isExportModifier)) setAwaitContext(/*value*/ true);
         const heritageClauses = parseHeritageClauses();
@@ -8179,6 +8191,9 @@ namespace Parser {
     function parseInterfaceDeclaration(pos: number, hasJSDoc: boolean, modifiers: NodeArray<ModifierLike> | undefined): InterfaceDeclaration {
         parseExpected(SyntaxKind.InterfaceKeyword);
         const name = parseIdentifier();
+        if (name.escapedText === "undefined") {
+            parseErrorAtRange(name, Diagnostics.Declaration_name_conflicts_with_built_in_global_identifier_0, "undefined");
+        }
         const typeParameters = parseTypeParameters();
         const heritageClauses = parseHeritageClauses();
         const members = parseObjectTypeMembers();
@@ -8192,6 +8207,9 @@ namespace Parser {
             parseErrorAtCurrentToken(Diagnostics.Line_break_not_permitted_here);
         }
         const name = parseIdentifier();
+        if (name.escapedText === "undefined") {
+            parseErrorAtRange(name, Diagnostics.Declaration_name_conflicts_with_built_in_global_identifier_0, "undefined");
+        }
         const typeParameters = parseTypeParameters();
         parseExpected(SyntaxKind.EqualsToken);
         const type = token() === SyntaxKind.IntrinsicKeyword && tryParse(parseKeywordAndNoDot) || parseType();
@@ -8215,6 +8233,9 @@ namespace Parser {
     function parseEnumDeclaration(pos: number, hasJSDoc: boolean, modifiers: NodeArray<ModifierLike> | undefined): EnumDeclaration {
         parseExpected(SyntaxKind.EnumKeyword);
         const name = parseIdentifier();
+        if (name.escapedText === "undefined") {
+            parseErrorAtRange(name, Diagnostics.Declaration_name_conflicts_with_built_in_global_identifier_0, "undefined");
+        }
         let members;
         if (parseExpected(SyntaxKind.OpenBraceToken)) {
             members = doOutsideOfYieldAndAwaitContext(() => parseDelimitedList(ParsingContext.EnumMembers, parseEnumMember));
@@ -8245,6 +8266,9 @@ namespace Parser {
         // propagate the 'Namespace' flag across the names if set.
         const namespaceFlag = flags & NodeFlags.Namespace;
         const name = flags & NodeFlags.NestedNamespace ? parseIdentifierName() : parseIdentifier();
+        if (name.escapedText === "undefined") {
+            parseErrorAtRange(name, Diagnostics.Declaration_name_conflicts_with_built_in_global_identifier_0, "undefined");
+        }
         const body = parseOptional(SyntaxKind.DotToken)
             ? parseModuleOrNamespaceDeclaration(getNodePos(), /*hasJSDoc*/ false, /*modifiers*/ undefined, NodeFlags.NestedNamespace | namespaceFlag) as NamespaceDeclaration
             : parseModuleBlock();
diff --git a/tests/baselines/reference/undefinedTypeAssignment1.errors.txt b/tests/baselines/reference/undefinedTypeAssignment1.errors.txt
@@ -1,8 +1,11 @@
+undefinedTypeAssignment1.ts(1,5): error TS2397: Declaration name conflicts with built-in global identifier 'undefined'.
 undefinedTypeAssignment1.ts(1,6): error TS2397: Declaration name conflicts with built-in global identifier 'undefined'.
 
 
-==== undefinedTypeAssignment1.ts (1 errors) ====
+==== undefinedTypeAssignment1.ts (2 errors) ====
     type undefined = string;
+        ~~~~~~~~~~
+!!! error TS2397: Declaration name conflicts with built-in global identifier 'undefined'.
          ~~~~~~~~~
 !!! error TS2397: Declaration name conflicts with built-in global identifier 'undefined'.
     function p(undefined = "wat") {
diff --git a/tests/baselines/reference/undefinedTypeAssignment4.errors.txt b/tests/baselines/reference/undefinedTypeAssignment4.errors.txt
@@ -1,20 +1,29 @@
+undefinedTypeAssignment4.ts(1,6): error TS2397: Declaration name conflicts with built-in global identifier 'undefined'.
 undefinedTypeAssignment4.ts(1,7): error TS2397: Declaration name conflicts with built-in global identifier 'undefined'.
+undefinedTypeAssignment4.ts(4,10): error TS2397: Declaration name conflicts with built-in global identifier 'undefined'.
 undefinedTypeAssignment4.ts(4,11): error TS2397: Declaration name conflicts with built-in global identifier 'undefined'.
+undefinedTypeAssignment4.ts(7,10): error TS2397: Declaration name conflicts with built-in global identifier 'undefined'.
 undefinedTypeAssignment4.ts(7,11): error TS2397: Declaration name conflicts with built-in global identifier 'undefined'.
 
 
-==== undefinedTypeAssignment4.ts (3 errors) ====
+==== undefinedTypeAssignment4.ts (6 errors) ====
     class undefined {
+         ~~~~~~~~~~
+!!! error TS2397: Declaration name conflicts with built-in global identifier 'undefined'.
           ~~~~~~~~~
 !!! error TS2397: Declaration name conflicts with built-in global identifier 'undefined'.
     	foo: string;
     }
     interface undefined {
+             ~~~~~~~~~~
+!!! error TS2397: Declaration name conflicts with built-in global identifier 'undefined'.
               ~~~~~~~~~
 !!! error TS2397: Declaration name conflicts with built-in global identifier 'undefined'.
     	member: number;
     }
     namespace undefined {
+             ~~~~~~~~~~
+!!! error TS2397: Declaration name conflicts with built-in global identifier 'undefined'.
               ~~~~~~~~~
 !!! error TS2397: Declaration name conflicts with built-in global identifier 'undefined'.
     	export var x = 42;
