Make parameter required

jakebailey · jakebailey · commit 6156ade8ba27 · 2023-08-03T14:20:24.000-07:00
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -21322,7 +21322,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
                         resetMaybeStack(/*markAllAsSucceeded*/ true);
                     }
                     else {
-                        resetMaybeStack();
+                        resetMaybeStack(/*markAllAsSucceeded*/ false);
                     }
                 }
                 // Note: it's intentional that we don't reset in the else case;
@@ -21333,11 +21333,11 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
                 // A false result goes straight into global cache (when something is false under
                 // assumptions it will also be false without assumptions)
                 relation.set(id, (reportErrors ? RelationComparisonResult.Reported : 0) | RelationComparisonResult.Failed | propagatingVarianceFlags);
-                resetMaybeStack();
+                resetMaybeStack(/*markAllAsSucceeded*/ false);
             }
             return result;
 
-            function resetMaybeStack(markAllAsSucceeded = false) {
+            function resetMaybeStack(markAllAsSucceeded: boolean) {
                 for (let i = maybeStart; i < maybeCount; i++) {
                     maybeKeysSet.delete(maybeKeys[i]);
                     if (markAllAsSucceeded) {

Original file line number	Diff line number	Diff line change
`@@ -21322,7 +21322,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {`
`21322`	`21322`	`resetMaybeStack(/markAllAsSucceeded/ true);`
`21323`	`21323`	`}`
`21324`	`21324`	`else {`
`21325`		`- resetMaybeStack();`
	`21325`	`+ resetMaybeStack(/markAllAsSucceeded/ false);`
`21326`	`21326`	`}`
`21327`	`21327`	`}`
`21328`	`21328`	`// Note: it's intentional that we don't reset in the else case;`
`@@ -21333,11 +21333,11 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {`
`21333`	`21333`	`// A false result goes straight into global cache (when something is false under`
`21334`	`21334`	`// assumptions it will also be false without assumptions)`
`21335`	`21335`	`relation.set(id, (reportErrors ? RelationComparisonResult.Reported : 0) \| RelationComparisonResult.Failed \| propagatingVarianceFlags);`
`21336`		`- resetMaybeStack();`
	`21336`	`+ resetMaybeStack(/markAllAsSucceeded/ false);`
`21337`	`21337`	`}`
`21338`	`21338`	`return result;`
`21339`	`21339`
`21340`		`- function resetMaybeStack(markAllAsSucceeded = false) {`
	`21340`	`+ function resetMaybeStack(markAllAsSucceeded: boolean) {`
`21341`	`21341`	`for (let i = maybeStart; i < maybeCount; i++) {`
`21342`	`21342`	`maybeKeysSet.delete(maybeKeys[i]);`
`21343`	`21343`	`if (markAllAsSucceeded) {`