Skip to content

Some number related columns are being imported by Nexus as null (tbl_MissingIndexes & tbl_dm_db_stats_properties) #393

Merged
PiJoCoder merged 17 commits intomicrosoft:masterfrom
hacitandogan:master
Apr 17, 2025
Merged

Some number related columns are being imported by Nexus as null (tbl_MissingIndexes & tbl_dm_db_stats_properties) #393
PiJoCoder merged 17 commits intomicrosoft:masterfrom
hacitandogan:master

Conversation

@hacitandogan
Copy link
Contributor

@hacitandogan hacitandogan commented Mar 26, 2025

Adresses #385

tbl_MissingIndexes
Fields defined as float but we have (.) dot in the text file for decimal places but float accepts a (,) comma
Changed below fields to varchar

improvement_measure
avg_total_user_cost
avg_user_impact
avg_total_system_cost
avg_system_impact

Missing Index report has a subtraction to calculate delta, modified the convert in the dataset.

tbl_dm_db_stats_properties
Changed below field to varchar
persisted_sample_percent

Null is expected for big tables with rows more than int max.
changed below fields to Bigint

Rows
rows_sampled
unfiltered_rows
modification_counter (may not be necessary but changing it anyway)

hacitandogan and others added 13 commits February 22, 2024 11:59
microsoft#310 fixed incorrect column data mapping in Tempdb Space usage report  grid
-removed the where clause ,the report is working now.
adding NexusReports.rptproj.rsuser to gitignore as we are always ignoring it manually , this should simplify it.
url in the main page was pointing to an older fix, updating it to latest so this will always navigate to the latest release.
…rs report

-added a secondary update for filters and filter_instances (for null values) to cover   unmatching decimal numbers , new updates are only using integer part of the altitude.
-updated the list for filter_driver_altitudes from https://github.com/MicrosoftDocs/windows-driver-docs/blob/staging/windows-driver-docs-pr/ifs/allocated-altitudes.md
…th session

-modified the warning to not run for 'sp_server_diagnostics session', 'hkenginexesession', 'system_health','alwayson_health','telemetry_xevents','xevent_SQLLogScout'
-added reference url to this warning.
-modified active traces&xevents report to not show expensive event field for Microsoft traces and xevents
-modified active traces&xevents  to show 'telemetry_xevents' as Microsoft trace too.
-removed the creation of this table and modified stored procedures to get accurate CPU number from [tbl_ServerProperties]
…f range convesion error

Dataset causing this conversion error (DataSet_SQL_CPU) is not even in use on this report.
Probably a left over from another report or an old grid / gauge.
Removing this to simplify.
microsoft#385

tbl_MissingIndexes
Fields defined as float but we have (.) dot in the text file for decimal places but float accepts a  (,) comma
Changed below fields to varchar

improvement_measure
avg_total_user_cost
avg_user_impact
avg_total_system_cost
avg_system_impact

Missing Index report has a subtraction to calculate delta, modified the convert in the dataset.

tbl_dm_db_stats_properties
Changed below field to varchar
persisted_sample_percent

Null is expected for big tables with rows more than int max.
changed below fields to Bigint

Rows
rows_sampled
unfiltered_rows
modification_counter (may not be necessary but changing it anyway)
@PiJoCoder
Copy link
Collaborator

For improvement_measure, the data type was changed to BIGINT in SQL LogScout (857). For the remaining float/decimal columns, if SQL Nexus is run on a non-English Windows, we have a separate issue #395

rowset -- Missing Indexes --

improvement_measure  is integer now to align with Logscout change
reverting following fields back to float to avoid any confisuon for decimal separator.

avg_total_user_cost
avg_user_impact
avg_total_system_cost
avg_system_impact

rowset -- sys.dm_db_stats_properties --

reverting persisted_sample_percent back to float to avoid any confisuon for decimal separator.

These will continue to be inserted as null until we revisit this topic.

Took the ownership of microsoft#361 and microsoft#395 to check this further.
improvement_measure is now bigint not int
@PiJoCoder
Copy link
Collaborator

Tested and it looks good

image

@PiJoCoder
Copy link
Collaborator

@hacitandogan could you build the process once so it copies the TextRowsets.xml with the latest update into the SQL Nexus folder. Thank you

…exus project

microsoft#385 Built the solution to update TextrowSets.xml under sqlnexus project
@PiJoCoder PiJoCoder merged commit 53bbd68 into microsoft:master Apr 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants