#387 - Removing 2 rowsets from the RowsetImporter#388
Merged
Conversation
Collaborator
|
Thanks for submitting this PR. Let’s take a slightly different approach. Instead of completely removing the rowsets, let’s keep them in there because in the future we might decide to re-introduce them and have to do the work of re-creating them. The way we can “disable” them is by changing the identifier For example change: From: "-- sysmail_event_log_sysmail_faileditems --" Joseph |
Collaborator
|
Thanks @asavioliMSFT. Can you build/compile the project so that the auto-generated sqlnexus/TextRowsets.xml also gets updated with your latest change. |
PiJoCoder
approved these changes
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On this PR, we are removing the rowsets below, since they contain columns with large texts and line breakers and fail to be imported.
sysmail_event_log_sysmail_faileditems
sysmail_log