Skip to content

Updates for #377 Non-Microsoft filter driver missing in the Filter drivers report and #380 expensive events#381

Merged
PiJoCoder merged 11 commits intomicrosoft:masterfrom
hacitandogan:master
Mar 21, 2025
Merged

Updates for #377 Non-Microsoft filter driver missing in the Filter drivers report and #380 expensive events#381
PiJoCoder merged 11 commits intomicrosoft:masterfrom
hacitandogan:master

Conversation

@hacitandogan
Copy link
Contributor

-added a secondary update for filters and filter_instances (for null values) to cover unmatching decimal numbers , new updates are only using integer part of the altitude.
-updated the list for filter_driver_altitudes from https://github.com/MicrosoftDocs/windows-driver-docs/blob/staging/windows-driver-docs-pr/ifs/allocated-altitudes.md

hacitandogan and others added 11 commits February 22, 2024 11:59
microsoft#310 fixed incorrect column data mapping in Tempdb Space usage report  grid
-removed the where clause ,the report is working now.
adding NexusReports.rptproj.rsuser to gitignore as we are always ignoring it manually , this should simplify it.
url in the main page was pointing to an older fix, updating it to latest so this will always navigate to the latest release.
…rs report

-added a secondary update for filters and filter_instances (for null values) to cover   unmatching decimal numbers , new updates are only using integer part of the altitude.
-updated the list for filter_driver_altitudes from https://github.com/MicrosoftDocs/windows-driver-docs/blob/staging/windows-driver-docs-pr/ifs/allocated-altitudes.md
…th session

-modified the warning to not run for 'sp_server_diagnostics session', 'hkenginexesession', 'system_health','alwayson_health','telemetry_xevents','xevent_SQLLogScout'
-added reference url to this warning.
-modified active traces&xevents report to not show expensive event field for Microsoft traces and xevents
-modified active traces&xevents  to show 'telemetry_xevents' as Microsoft trace too.
-removed the creation of this table and modified stored procedures to get accurate CPU number from [tbl_ServerProperties]
…f range convesion error

Dataset causing this conversion error (DataSet_SQL_CPU) is not even in use on this report.
Probably a left over from another report or an old grid / gauge.
Removing this to simplify.
@PiJoCoder
Copy link
Collaborator

@hacitandogan, I have completely missed the existence of this PR. Let's discuss this and merge it next week.

@PiJoCoder
Copy link
Collaborator

PiJoCoder commented Mar 20, 2025

  • Tested OtherWaits report. Works fine now

    image

  • Confirmed tbl_sysinfo is no longer there

  • Tested the Warning about expensive events by doing the following:

    • Switched to master branch and built SQL Nexus and imported a SQL LogScout GeneralPerf collection. Got this output
      image
    • Switched to this PR's branch and built SQL Nexus and imported a the same LogScout GeneralPerf collection. Got this output
      image
  • Tested importing a collection with Non-MS filter drivers. Looks good - they show up in the top table

    image

@PiJoCoder PiJoCoder changed the title updates for #377 Non-Microsoft filter driver missing in the Filter drivers report Updates for #377 Non-Microsoft filter driver missing in the Filter drivers report and #380 Mar 20, 2025
@PiJoCoder PiJoCoder changed the title Updates for #377 Non-Microsoft filter driver missing in the Filter drivers report and #380 Updates for #377 Non-Microsoft filter driver missing in the Filter drivers report and #380 expensive events Mar 20, 2025
Copy link
Contributor

@asavioliMSFT asavioliMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirmed that now the antivirus name is being displayed.

@PiJoCoder PiJoCoder merged commit b46717d into microsoft:master Mar 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants