QueryStore_Additional_Data sys.dm_db_tuning_recommendations#312
Merged
3 commits merged intomicrosoft:masterfrom Mar 13, 2024
Merged
Conversation
Added new columns and table for QS modifications.
Removed the comments in the code
PiJoCoder
reviewed
Mar 13, 2024
PiJoCoder
requested changes
Mar 13, 2024
Collaborator
PiJoCoder
left a comment
There was a problem hiding this comment.
Looks good - tested the functionality and it works great.
Just recompile the solution and let the TextRowset.xml file be automatically generated in the \SQLNexus folder
Remove comments
cae5153
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new columns and table for QS modifications.
Added columns force_failure_count, last_force_failure_reason_desc and plan_forcing_type_desc to table sys.query_store_plan. Also, added new table tbl_dm_db_tuning_recommendations to collect auto tune recommendations from new query in SQLLogScout for sys.dm_db_tuning_recommendations.