Skip to content

Implement <flat_set>#3817

Merged
StephanTLavavej merged 26 commits into
microsoft:feature/flat_setfrom
Saalvage:feature/flat_set
Jun 22, 2023
Merged

Implement <flat_set>#3817
StephanTLavavej merged 26 commits into
microsoft:feature/flat_setfrom
Saalvage:feature/flat_set

Conversation

@Saalvage

@Saalvage Saalvage commented Jun 21, 2023 •
edited by StephanTLavavej
Loading

Copy link
Copy Markdown
Contributor

Sadly, tests are mostly missing!

Works towards #2912.

@Saalvage Saalvage requested a review from a team as a code owner June 21, 2023 00:35
@StephanTLavavej StephanTLavavej added the flat_meow C++23 container adaptors label Jun 21, 2023
frederick-vs-ja
frederick-vs-ja reviewed Jun 21, 2023
View reviewed changes
Comment thread stl/inc/flat_set Outdated
Comment thread stl/inc/flat_set Outdated
Comment thread stl/inc/xutility Outdated
AlexGuteniev
AlexGuteniev suggested changes Jun 21, 2023
View reviewed changes
Comment thread stl/inc/flat_set Outdated
Comment thread stl/inc/yvals_core.h Outdated
StephanTLavavej
StephanTLavavej requested changes Jun 21, 2023
View reviewed changes
Comment thread stl/inc/flat_set
@StephanTLavavej

This comment was marked as resolved.

Sign in to view
@StephanTLavavej

This comment was marked as resolved.

Sign in to view
@Saalvage @StephanTLavavej @AlexGuteniev
CXX23 guards
fb1bf79 
Co-Authored-By: Stephan T. Lavavej <[email protected]>
Co-Authored-By: Alex Guteniev <[email protected]>
@Saalvage

This comment was marked as resolved.

Sign in to view
StephanTLavavej
StephanTLavavej reviewed Jun 22, 2023
View reviewed changes
Comment thread tests/std/tests/P1222R4_flat_set/env.lst
Comment thread stl/inc/yvals_core.h Outdated
Comment thread stl/inc/yvals_core.h Outdated
Comment thread stl/inc/yvals_core.h Outdated
Comment thread tests/std/tests/P1502R1_standard_library_header_units/importable_cxx_library_headers.jsonc
Comment thread stl/inc/flat_set Outdated
Comment thread tests/std/tests/P1222R4_flat_set/test.cpp Outdated
Comment thread tests/std/tests/P1222R4_flat_set/test.cpp Outdated
Comment thread tests/std/tests/P1222R4_flat_set/test.cpp
Comment thread tests/std/tests/P1222R4_flat_set/test.cpp Outdated
@StephanTLavavej

StephanTLavavej commented Jun 22, 2023

Copy link
Copy Markdown
Member

Thanks! I fully reviewed all of the supporting files, and lightly reviewed <flat_set> and its test.cpp. (I'll do a more thorough review later, of course.) I've pushed changes for the superficial issues I found, and I'll merge this after the tests pass, so other contributors can begin looking into it.

@StephanTLavavej StephanTLavavej merged commit d8ef55d into microsoft:feature/flat_set Jun 22, 2023
@Saalvage Saalvage deleted the feature/flat_set branch June 22, 2023 16:02
@grcm10 grcm10 mentioned this pull request Oct 2, 2023
Merged
15 tasks
@StephanTLavavej StephanTLavavej mentioned this pull request Feb 4, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+2 more reviewers

@frederick-vs-ja frederick-vs-ja frederick-vs-ja left review comments

@AlexGuteniev AlexGuteniev AlexGuteniev requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flat_meow C++23 container adaptors

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Saalvage @StephanTLavavej @AlexGuteniev @frederick-vs-ja @strega-nil-ms