<ranges>: Strengthen exception specification for _Defaultabox#3762
Merged
StephanTLavavej merged 3 commits intoJun 15, 2023
Conversation
Contributor
|
|
Member
|
@achabense is correct - we typically don't bother with "strengthened" comments for things that don't appear in the Standard. (For things that directly correspond to exposition-only functions, I think sometimes we do, but I forget specific examples.) |
StephanTLavavej
added
enhancement
Contributor
|
There are also a lot of |
StephanTLavavej
approved these changes
Jun 12, 2023
CaseyCarter
approved these changes
Jun 12, 2023
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
🦾
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One non-defaulted move constructor for
_Defaultaboxis currently nevernoexcept, which is probably a bug.So I decided not to add// strengthenedto that move constructor. Some similar constructors are made conditionallynoexcept, and I think// strengthenedis suitable for them._Defaultaboxis used forjoin_view::_Iteratorandlazy_split_view, while the standard wording usesoptionalandnon-propagating-cacherespectively. And thus I'm afraid that the exception specifications are not yet strong enough forlazy_split_view. But further strengthening seems dangerous.