Skip to content

Cleanup elements when resize fails in deque(n)#3720

Merged
StephanTLavavej merged 1 commit into
microsoft:mainfrom
CaseyCarter:deque_leak
May 30, 2023
Merged

Cleanup elements when resize fails in deque(n)#3720
StephanTLavavej merged 1 commit into
microsoft:mainfrom
CaseyCarter:deque_leak

Conversation

@CaseyCarter
Copy link
Copy Markdown
Contributor

Fixes #3717

@CaseyCarter CaseyCarter added the bug Something isn't working label May 19, 2023
@CaseyCarter CaseyCarter requested a review from a team as a code owner May 19, 2023 19:48
@StephanTLavavej StephanTLavavej self-assigned this May 26, 2023
@StephanTLavavej
Copy link
Copy Markdown
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 15dd2ab into microsoft:main May 30, 2023
@StephanTLavavej
Copy link
Copy Markdown
Member

Thanks for fixing this major bug in the STL's most important container! 😹 🐞 🎉

@CaseyCarter CaseyCarter deleted the deque_leak branch May 31, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deque(size_t,const Allocator&) doesn't clear up constructed elements on exception

3 participants