.vscode/settings.json: Teach Pylance about our paths#3040
Conversation
|
I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. (I am a bit of a greedy kitty for fast-tracking my own PR before anyone has seen it - but as usual it will be fully reviewed and either approved or held back before merging. 🍗 🐈) |
strega-nil-ms
left a comment
strega-nil-ms
left a comment
There was a problem hiding this comment.
I don't personally know much about python, but this seems reasonable to me.
| "./llvm-project/libcxx/utils", | ||
| "./llvm-project/llvm/utils/lit", | ||
| "./tests/utils" |
There was a problem hiding this comment.
Is there a reason we're ./ing these paths? They're relative to the workspace folder anyways.
There was a problem hiding this comment.
seems like it makes things more explicit, I don't mind this as a style choice
There was a problem hiding this comment.
I was simply confused about whether ./ was necessary - I had tried a bunch of paths, added ./, then found something that worked and didn't think to try removing ./.
There was a problem hiding this comment.
As everyone has approved, I'd like to avoid resetting testing and land this as-is, but I'll clean up the ./s in a followup PR since they weren't really an intentional style choice on my part.
4 participants
This tells VSCode's Python extension, Pylance, where to find our test support machinery, so that modules can be fully resolved without squiggles.
(I found these paths by the ultra-scientific method of opening all of our
.pyfiles, and seeing which modules generated squiggles. With these paths, onlypsutilneeds to be installed locally in order to resolve one remaining squiggle.)🐍