Test ASAN SSO string copies; improve basic_string::_Construct preconditions#3039
Merged
Conversation
To avoid regressing DevCom-10116361 / VSO-1590908 Also: Document `_Construct` precondition that elements must be value-initialized, use in all branches.
CaseyCarter
force-pushed
the
ASAN-SSO-fix
branch
2 times, most recently
from
6c731bc to
7bef7d3
Compare
StephanTLavavej
approved these changes
Aug 19, 2022
Member
|
Looks good, I pushed |
Contributor
Author
GRAWR. I can't believe I double-checked |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for enhancing this test coverage and improving bug resistance here! ✅ 🐞 😻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid regressing DevCom-10116361 / VSO-1590908
Reviewer note: I did temporarily enable ASAN annotation and verify that all tests (including the new regression test) pass.