Use non-strict matrices where possible#3015
Merged
Merged
Conversation
We've been a bit lax about using the `strict_concepts_meow` test matrices which omit `/permissive` configs. Use the plain `concepts_meow` matrices instead for tests that pass with `/permissive`.
StephanTLavavej
approved these changes
Aug 9, 2022
strega-nil-ms
approved these changes
Aug 10, 2022
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
No one can be told what the non-strict matrix is - you have to compile it for yourself. 🕶️ 🖥️ 💊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've been a bit lax about using the
strict_concepts_meowtest matrices, which omit/permissiveconfigs, when we don't really need to. Use the plainconcepts_meowmatrices instead for tests that pass with/permissive.After this, the remaining strict tests are:
P0323R12_expectedP0896R4_common_iteratorP0896R4_views_dropP0896R4_views_elementsP0896R4_views_filterP0896R4_views_filter_deathP0896R4_views_filter_iteratorP0896R4_views_joinP0896R4_views_lazy_splitP0896R4_views_splitP0896R4_views_takeP0896R4_views_transformP1522R1_difference_typeP1899R3_views_strideP2441R2_views_join_with