<format>: all nans are "nan"#3001
Merged
Merged
Conversation
CaseyCarter
commented
Aug 6, 2022
StephanTLavavej
approved these changes
Aug 7, 2022
Member
|
Thanks - this looks correct to me, we have sufficient buffer size, and all codepaths appear to be modified/tested. I pushed really trivial changes since I had to find something. 😹 |
Contributor
|
Thanks for the quick fix @CaseyCarter |
strega-nil-ms
approved these changes
Aug 8, 2022
Contributor
strega-nil-ms
left a comment
strega-nil-ms
left a comment
There was a problem hiding this comment.
Thanks @CaseyCarter
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for fixing this bug! 🐞 🧮 😸 |
fsb4000
pushed a commit
to fsb4000/STL
that referenced
this pull request
Aug 13, 2022
Co-authored-by: Stephan T. Lavavej <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... per [format.string.std]/22.
Reported by Mark de Wever after we tried to break their perfectly good test with https://reviews.llvm.org/D131336.