Temporarily disable ASAN string annotations #2990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
approved these changes
Aug 4, 2022
Member
|
Internal mirror: MSVC-PR-414948 |
CaseyCarter
approved these changes
Aug 4, 2022
strega-nil
pushed a commit
to strega-nil/stl
that referenced
this pull request
Aug 6, 2022
Temporarily disable ASAN string annotations.
fsb4000
pushed a commit
to fsb4000/STL
that referenced
this pull request
Aug 13, 2022
Temporarily disable ASAN string annotations.
|
Thanks for working on the ASAN annotations! 😄 Maybe you are aware of this already, but this feature unfortunately causes issues, as explained here (but also in 64-bit builds): https://developercommunity.visualstudio.com/t/VS2022---Address-sanitizer-on-x86-Debug-/10116361 Just wondering, have the ASAN string annotations been disabled because of this? |
|
Because it miss null-terminated #ifdef _INSERT_STRING_ANNOTATION |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabling string annotations to unblock ASAN testing. Work to re-enable is ongoing.