Implement LWG-3719: Directory iterators should be usable with default sentinel#2902
Merged
Merged
Conversation
26 tasks
CaseyCarter
added
LWG
CaseyCarter
suggested changes
Jul 25, 2022
Contributor
Author
|
It seems that we haven't silenced clang's warning for |
Contributor
In produce code, we have, but tests need to do so individually as desired. (i.e., go ahead and suppress it if you want) EDIT: Yes, I mean "product code" - but "produce code" sounds so healthy and appetizing. |
Advancing beginning iterators to the end.
CaseyCarter
approved these changes
Jul 26, 2022
StephanTLavavej
approved these changes
Jul 26, 2022
StephanTLavavej
approved these changes
Jul 26, 2022
Member
|
Pushed changes to address @strega-nil-ms's feedback, plus the minor stylistic issue I noticed earlier since we're rerunning tests anyways. |
CaseyCarter
approved these changes
Jul 27, 2022
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for implementing so many LWG issue resolutions and improving conformance! 😻 😻 😻 |
fsb4000
pushed a commit
to fsb4000/STL
that referenced
this pull request
Aug 13, 2022
… sentinel (microsoft#2902) Co-authored-by: Stephan T. Lavavej <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #2872. Adding test coverage to the test file for stream iterators and
default_sentinel_t.