fix analyze in CI#2812
Merged
Merged
Conversation
CaseyCarter
reviewed
Jun 21, 2022
…er' on _Param_(4) does not apply to a value type.
StephanTLavavej
approved these changes
Jun 21, 2022
CaseyCarter
suggested changes
Jun 21, 2022
| // TRANSITION, ABI: preserved for binary compatibility | ||
| extern "C" _CRTIMP2 VOID __cdecl __crtSetThreadpoolTimer(_Inout_ PTP_TIMER const pti, | ||
| _In_opt_ PFILETIME const pftDueTime, _In_ DWORD const msPeriod, _In_opt_ DWORD const msWindowLength) { | ||
| _In_opt_ PFILETIME const pftDueTime, _In_ DWORD const msPeriod, _In_ DWORD const msWindowLength) { |
Contributor
There was a problem hiding this comment.
For posterity: this is the only occurrence of _In_opt_ applied to a non-pointer type in the STL. (No change requested.)
CaseyCarter
approved these changes
Jun 23, 2022
StephanTLavavej
approved these changes
Jun 23, 2022
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for finding and fixing how this important compiler option was silently missing! 🔍 🎉 😸 |
4 tasks
fsb4000
pushed a commit
to fsb4000/STL
that referenced
this pull request
Aug 13, 2022
Co-authored-by: nicole mazzuca <[email protected]> Co-authored-by: Stephan T. Lavavej <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2810