Skip to content

<complex>: fix complex division by zero#2758

Merged
StephanTLavavej merged 8 commits into
microsoft:mainfrom
fsb4000:fix2728
Jun 12, 2022
Merged

<complex>: fix complex division by zero#2758
StephanTLavavej merged 8 commits into
microsoft:mainfrom
fsb4000:fix2728

Conversation

@fsb4000
Copy link
Copy Markdown
Contributor

@fsb4000 fsb4000 commented Jun 3, 2022 •
edited
Loading

@fsb4000 fsb4000 requested a review from a team as a code owner June 3, 2022 19:25
@fsb4000 fsb4000 marked this pull request as draft June 3, 2022 19:37
@fsb4000 fsb4000 marked this pull request as ready for review June 3, 2022 20:24
@StephanTLavavej StephanTLavavej added bug Something isn't working high priority Important! labels Jun 3, 2022
StephanTLavavej
StephanTLavavej reviewed Jun 4, 2022
View reviewed changes
Comment thread stl/inc/complex Outdated
Comment thread stl/inc/complex Outdated
Comment thread tests/std/tests/Dev10_555491_complex_linker_errors/test.cpp Outdated
Comment thread tests/std/tests/Dev10_555491_complex_linker_errors/test.cpp Outdated
@StephanTLavavej

This comment was marked as resolved.

Sign in to view
statementreply
statementreply reviewed Jun 5, 2022
View reviewed changes
Comment thread stl/inc/complex Outdated
fsb4000 and others added 2 commits June 5, 2022 15:46
@fsb4000 fsb4000 requested a review from StephanTLavavej June 5, 2022 13:02
strega-nil-ms
strega-nil-ms approved these changes Jun 9, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@strega-nil-ms strega-nil-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@strega-nil-ms strega-nil-ms removed their assignment Jun 9, 2022
@StephanTLavavej StephanTLavavej self-assigned this Jun 10, 2022
@StephanTLavavej
Copy link
Copy Markdown
Member

StephanTLavavej commented Jun 10, 2022

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 12efbdb into microsoft:main Jun 12, 2022
@StephanTLavavej
Copy link
Copy Markdown
Member

StephanTLavavej commented Jun 12, 2022

Thanks for fixing this high priority user-reported bug! Who knew that division by zero was so important! 0️⃣ 😹 🎉

@fsb4000
Copy link
Copy Markdown
Contributor Author

fsb4000 commented Jun 12, 2022

Yeah, I have failed to change 2 lines of the product code :)
Thanks @statementreply for suggestion the correct fix 🎉

@fsb4000 fsb4000 deleted the fix2728 branch June 12, 2022 13:19
fsb4000 added a commit to fsb4000/STL that referenced this pull request Aug 13, 2022
@fsb4000 @StephanTLavavej @statementreply
<complex>: fix complex division by zero (microsoft#2758)
5ccea27 
Co-authored-by: Stephan T. Lavavej <[email protected]>
Co-authored-by: statementreply <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+2 more reviewers

@statementreply statementreply statementreply left review comments

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej StephanTLavavej

Labels

bug Something isn't working high priority Important!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

<complex>: Implementation divergence for division by zero

4 participants

@fsb4000 @StephanTLavavej @statementreply @strega-nil-ms