Skip to content

syserror.cpp: add more matches against std::errc::timed_out#2744

Merged
StephanTLavavej merged 1 commit into
microsoft:mainfrom
fsb4000:fix2572
Jul 1, 2022
Merged

syserror.cpp: add more matches against std::errc::timed_out#2744
StephanTLavavej merged 1 commit into
microsoft:mainfrom
fsb4000:fix2572

Conversation

@fsb4000
Copy link
Copy Markdown
Contributor

@fsb4000 fsb4000 commented May 27, 2022

Fixes #2572

This PR affects redist.

It is expected that the fix can be included in VS 2022 17.4 Preview 2.

So this PR is blocked for now.

@fsb4000 fsb4000 requested a review from a team as a code owner May 27, 2022 14:48
@CaseyCarter CaseyCarter added enhancement Something can be improved affects redist labels May 27, 2022
@StephanTLavavej
Copy link
Copy Markdown
Member

StephanTLavavej commented May 27, 2022

I verified that these are documented system error codes (and that we aren't mixing unrelated error codes into this table).

@StephanTLavavej
Copy link
Copy Markdown
Member

StephanTLavavej commented May 27, 2022

Marking as blocked - in theory we could merge this without waiting for 17.4 Preview 2 (as we've overcome our initial reluctance to merge redist-affecting changes, as long as coordinated header changes aren't necessary). However, since it's coming soon-ish, we may as well bundle this with #2742.

@StephanTLavavej StephanTLavavej added the blocked Something is preventing work on this label May 27, 2022
@StephanTLavavej StephanTLavavej removed the blocked Something is preventing work on this label Jun 29, 2022
@StephanTLavavej StephanTLavavej self-assigned this Jun 30, 2022
@StephanTLavavej
Copy link
Copy Markdown
Member

StephanTLavavej commented Jun 30, 2022

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 4e3fb31 into microsoft:main Jul 1, 2022
@StephanTLavavej
Copy link
Copy Markdown
Member

StephanTLavavej commented Jul 1, 2022

Thanks for improving our list of error codes! ✅ 🎉 🐱

@fsb4000 fsb4000 deleted the fix2572 branch July 1, 2022 04:11
@StephanTLavavej StephanTLavavej mentioned this pull request Jul 1, 2022
Merged
fsb4000 added a commit to fsb4000/STL that referenced this pull request Aug 13, 2022
@fsb4000
syserror.cpp: add more matches against std::errc::timed_out (microsof…
2fb43a5 
…t#2744)
@pdimov pdimov mentioned this pull request Nov 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+1 more reviewer

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej StephanTLavavej

Labels

enhancement Something can be improved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

<system_error>: WAIT_TIMEOUT is not matched against by std::errc::timed_out

4 participants

@fsb4000 @StephanTLavavej @strega-nil-ms @CaseyCarter