Skip to content

Cleanups 5: if constexpr for <scoped_allocator> operator==#2677

Merged
StephanTLavavej merged 1 commit into
microsoft:mainfrom
StephanTLavavej:cleanups-5-if-constexpr
May 1, 2022
Merged

Cleanups 5: if constexpr for <scoped_allocator> operator==#2677
StephanTLavavej merged 1 commit into
microsoft:mainfrom
StephanTLavavej:cleanups-5-if-constexpr

Conversation

@StephanTLavavej
Copy link
Copy Markdown
Member

@StephanTLavavej StephanTLavavej commented Apr 27, 2022

This combines 2 namespace-scope functions into the 1 function depicted by [scoped.adaptor.operators].

Noticed while marking functions as export. Works towards #189.

@StephanTLavavej StephanTLavavej added the throughput Must compile faster label Apr 27, 2022
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner April 27, 2022 20:59
@strega-nil-ms strega-nil-ms self-assigned this Apr 27, 2022
@CaseyCarter CaseyCarter removed their assignment Apr 28, 2022
Comment thread stl/inc/scoped_allocator
@strega-nil-ms strega-nil-ms removed their assignment Apr 28, 2022
@StephanTLavavej StephanTLavavej self-assigned this Apr 30, 2022
@StephanTLavavej
Copy link
Copy Markdown
Member Author

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit aaa0863 into microsoft:main May 1, 2022
@StephanTLavavej StephanTLavavej deleted the cleanups-5-if-constexpr branch May 1, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

throughput Must compile faster

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants