In addition to following our conventions, these [[noreturn]] helpers can improve codegen by helping the compiler see that the EH-throwing paths are unlikely, thus separating out their large codegen and allowing the remaining small codegen (for the success path) to be potentially inlined.

I think this is more agressively achieved by adding __declspec(noinline), just [[noreturn]] does not neccessarily do it.

Yeah, if we ever saw a case where the backend decided to inline a [[noreturn]] helper, we could add __declspec(noinline) (and probably report it to the optimizer team). I'm not aware of such cases so I think pre-emptively adding it would be unnecessary.

Is [[noreturn]] by default [[unlikely]]?
It doesn't like like it in the documentation:
https://docs.microsoft.com/en-us/cpp/cpp/noreturn?view=msvc-170

@robert-andrzejuk

Is [[noreturn]] by default [[unlikely]]?

My understanding is that it is effectively treated as such (I believe I learned this from @BillyONeal) but it isn't necessarily documented that way.

@strega-nil-ms @barcharcraz @CaseyCarter I have changed the exception messages as follows:

C:\Temp>type meow.cpp

#include <format>
#include <iostream>
using namespace std;

template <typename... Args>
void try_vformat(Args... args) {
    try {
        (void) vformat(args...);
    } catch (const format_error& e) {
        cout << "format_error: " << e.what() << endl;
    }
}

int main() {
    try_vformat("{:g}", make_format_args('a'));
    try_vformat(L"{:g}", make_wformat_args(L'a'));
    try_vformat("{:c}", make_format_args(1729));
    try_vformat(L"{:c}", make_wformat_args(70'000));
}

C:\Temp>cl /EHsc /nologo /W4 /std:c++20 meow.cpp && meow
meow.cpp
format_error: Invalid presentation type for char
format_error: Invalid presentation type for wchar_t
format_error: integral cannot be stored in char
format_error: integral cannot be stored in wchar_t

Closing and reopening to fix the CLA check.

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.