Skip to content

Reduce _Invoker_ret specializations with if constexpr#2668

Merged
StephanTLavavej merged 4 commits into
microsoft:mainfrom
AlexGuteniev:unspecialize
May 5, 2022
Merged

Reduce _Invoker_ret specializations with if constexpr#2668
StephanTLavavej merged 4 commits into
microsoft:mainfrom
AlexGuteniev:unspecialize

Conversation

@AlexGuteniev
Copy link
Copy Markdown
Contributor

Towards #189

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner April 23, 2022 12:21
Comment thread stl/inc/functional
Copy link
Copy Markdown
Contributor

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the noexcept specification is indeed equivalent

@StephanTLavavej StephanTLavavej added the throughput Must compile faster label Apr 26, 2022
@StephanTLavavej StephanTLavavej self-assigned this Apr 27, 2022
Comment thread stl/inc/functional
@strega-nil-ms strega-nil-ms removed their assignment May 3, 2022
@StephanTLavavej StephanTLavavej self-assigned this May 5, 2022
@StephanTLavavej
Copy link
Copy Markdown
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 0a618df into microsoft:main May 5, 2022
@AlexGuteniev AlexGuteniev deleted the unspecialize branch May 5, 2022 09:14
@StephanTLavavej
Copy link
Copy Markdown
Member

Thanks for improving throughput in this important codepath! (The invoke family is one of the most heavily instantiated.) 🚀 😻 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

throughput Must compile faster

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants