avoid relink msvcp140_atomic_wait_oss.dll#2606
Merged
Merged
Conversation
CaseyCarter
reviewed
Mar 14, 2022
StephanTLavavej
approved these changes
Mar 14, 2022
Member
|
Verified that this works as expected, thank you! 😻 |
CaseyCarter
approved these changes
Mar 14, 2022
Contributor
CaseyCarter
left a comment
CaseyCarter
left a comment
There was a problem hiding this comment.
Confirmed that relinking doesn't occur after running cmake with no changes for a completed build.
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for fixing the build system for optimal incremental builds! 😻 😻 😻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2605
From cmake help:
Generated files are modified and their timestamp updated on subsequent cmake runs only if their content is changed.