Skip to content

Implement P2273R3 constexpr unique_ptr#2582

Merged
StephanTLavavej merged 12 commits into
microsoft:mainfrom
fsb4000:fix2535
Mar 17, 2022
Merged

Implement P2273R3 constexpr unique_ptr#2582
StephanTLavavej merged 12 commits into
microsoft:mainfrom
fsb4000:fix2535

Conversation

@fsb4000
Copy link
Copy Markdown
Contributor

@fsb4000 fsb4000 commented Feb 19, 2022 •
edited by StephanTLavavej
Loading

Fixes #2535

I added tests and they pass with clang-cl and fail with cl.exe and EDG :(

(The test now contains workarounds citing DevCom-1436243 and DevCom-1670927.)

@fsb4000 fsb4000 requested a review from a team as a code owner February 19, 2022 15:37
@AlexGuteniev

This comment was marked as resolved.

Sign in to view
@fsb4000

This comment was marked as resolved.

Sign in to view
frederick-vs-ja
frederick-vs-ja reviewed Feb 19, 2022
View reviewed changes
Comment thread stl/inc/yvals_core.h Outdated
@CaseyCarter CaseyCarter added the cxx23 C++23 feature label Feb 21, 2022
@StephanTLavavej StephanTLavavej self-assigned this Feb 23, 2022
StephanTLavavej
StephanTLavavej reviewed Mar 3, 2022
View reviewed changes
Comment thread tests/std/tests/P2273R3_constexpr_unique_ptr/test.compile.pass.cpp Outdated
Comment thread tests/std/tests/P2273R3_constexpr_unique_ptr/test.compile.pass.cpp Outdated
Comment thread tests/std/tests/P2273R3_constexpr_unique_ptr/test.compile.pass.cpp
Comment thread tests/std/tests/P2273R3_constexpr_unique_ptr/test.compile.pass.cpp Outdated
Comment thread tests/std/tests/P2273R3_constexpr_unique_ptr/test.compile.pass.cpp
Comment thread tests/std/tests/P2273R3_constexpr_unique_ptr/test.compile.pass.cpp
Comment thread tests/std/tests/P2273R3_constexpr_unique_ptr/test.compile.pass.cpp Outdated
Comment thread tests/std/tests/P2273R3_constexpr_unique_ptr/test.compile.pass.cpp Outdated
Comment thread tests/std/tests/P2273R3_constexpr_unique_ptr/test.compile.pass.cpp Outdated
Comment thread tests/std/tests/P2273R3_constexpr_unique_ptr/test.compile.pass.cpp
@StephanTLavavej StephanTLavavej removed their assignment Mar 3, 2022
@StephanTLavavej
Copy link
Copy Markdown
Member

StephanTLavavej commented Mar 3, 2022

Thanks! The product code looked perfect, couldn't find even a single nitpick. 😻 Had a few suggestions for the test, but they were all tiny, so I went ahead and pushed changes for them.

@AraHaan
Copy link
Copy Markdown

AraHaan commented Mar 3, 2022

Wait unique_ptr is now constexpr? nice.

@barcharcraz barcharcraz removed their assignment Mar 12, 2022
@StephanTLavavej
Copy link
Copy Markdown
Member

StephanTLavavej commented Mar 15, 2022

I've pushed a merge with main to resolve a trivial adjacent-add conflict in yvals_core.h.

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej self-assigned this Mar 15, 2022
@StephanTLavavej StephanTLavavej merged commit 430bb0a into microsoft:main Mar 17, 2022
@StephanTLavavej
Copy link
Copy Markdown
Member

StephanTLavavej commented Mar 17, 2022

Thanks for implementing and carefully testing this feature! 🚀 ✅ 😻

@fsb4000 fsb4000 deleted the fix2535 branch March 17, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+2 more reviewers

@frederick-vs-ja frederick-vs-ja frederick-vs-ja left review comments

@barcharcraz barcharcraz barcharcraz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej StephanTLavavej

Labels

cxx23 C++23 feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

P2273R3 constexpr unique_ptr

7 participants

@fsb4000 @AlexGuteniev @StephanTLavavej @AraHaan @barcharcraz @frederick-vs-ja @CaseyCarter