Skip to content

Prefer friend constexpr to constexpr friend#2419

Merged
StephanTLavavej merged 2 commits into
microsoft:mainfrom
CaseyCarter:friend_constexpr
Dec 17, 2021
Merged

Prefer friend constexpr to constexpr friend#2419
StephanTLavavej merged 2 commits into
microsoft:mainfrom
CaseyCarter:friend_constexpr

Conversation

@CaseyCarter
Copy link
Copy Markdown
Contributor

@CaseyCarter CaseyCarter commented Dec 14, 2021

We've had a few of the latter sneak in - let's correct them now.

Totally unrelated drive-by: Skip flaky libcxx test that detaches threads. (See https://dev.azure.com/vclibs/STL/_build/results?buildId=9815&view=ms.vss-test-web.build-test-results-tab&runId=1172522&resultId=101145&paneView=debug)

We've had a few of the latter sneak in - let's correct them now.
@StephanTLavavej StephanTLavavej self-assigned this Dec 16, 2021
@StephanTLavavej
Copy link
Copy Markdown
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 3318135 into microsoft:main Dec 17, 2021
@StephanTLavavej
Copy link
Copy Markdown
Member

Thanks for these cleanups! 🧹 ✨ 😻

@CaseyCarter CaseyCarter deleted the friend_constexpr branch December 17, 2021 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Something can be improved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants