Implement LWG-3571 and LWG-3570: flush_emit set badbit if the emit call fails#2418
Conversation
Co-authored-by: Michael Schellenberger Costa <[email protected]>
flush_emit set badbit if the emit call failsflush_emit set badbit if the emit call fails
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Matt Stephanson <[email protected]>
Co-authored-by: Matt Stephanson <[email protected]>
|
Thanks, this looks solid! The only things I noticed were stylistic nitpicks, so I went ahead and pushed a merge with |
| if (!_Ok) { | ||
| _State |= ios_base::badbit; | ||
| } else { | ||
| _TRY_IO_BEGIN |
There was a problem hiding this comment.
God I really don't like these, it's pre-existing (and changing it would be ... a project) so don't consider this a change request, but maybe we should open an issue.
Co-authored-by: Charlie Barto <[email protected]>
|
Thanks - I approve of the ternary-to- |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for syncing the implementation with the Standard's stream of LWG issues! 😹 🚀 🎉 |
Fixes #2396
Fixes #2395