Don't /LTCG CRT initializers#2314
Merged
StephanTLavavej merged 1 commit intomicrosoft:mainfrom Nov 13, 2021
Merged
Conversation
CaseyCarter
commented
Nov 1, 2021
StephanTLavavej
approved these changes
Nov 1, 2021
AlexGuteniev
approved these changes
Nov 1, 2021
Contributor
AlexGuteniev
left a comment
AlexGuteniev
left a comment
There was a problem hiding this comment.
After TryAcquireSRWLockExclusive is impoerted statically due to Vista drop, the only way to observe the difference would be __crtGetSystemTimePreciseAsFileTime, which affects system_clock::now() granularity. I don't think we need a test for it.
Member
|
I have manually verified the fix. // cl /EHsc /nologo /W4 /MD /Zi /Fdmeow.pdb meow.cpp
#include <cstdio>
#include <mutex>
using namespace std;
int main() {
mutex mut;
puts("BEFORE");
mut.lock();
puts("DURING");
mut.unlock();
puts("AFTER");
}Before this PR, stepping into
After this PR, it calls:
|
cbezault
approved these changes
Nov 8, 2021
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks @AlexGuteniev for finding and @CaseyCarter for fixing this lurking bug! 🐞 🛠️ 😸 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2311
I verified the fix manually; open to suggestions for test coverage.