Fix chronat tests to deal with locale-dependent time zones abbreviations#2231
Merged
Merged
Conversation
StephanTLavavej
approved these changes
Oct 27, 2021
Member
|
Thanks for fixing these test failures - both when the US time zones aren't available, and the Australian time zones are! 😻 I went ahead and pushed a small cleanup to reduce code repetition, and a conflict-free merge with |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed, or if more work is required. |
mnatsuhara
approved these changes
Nov 12, 2021
Member
|
Thanks for fixing these spurious test failures so the whole world can enjoy chronat testing! 🌏 🌍 🌎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1904.