<format>: fix invalid handling of large precisions#2157
Merged
Conversation
AdamBucior
reviewed
Aug 25, 2021
StephanTLavavej
changed the title
<format>: fix invalid handling of large precisions
AdamBucior
reviewed
Aug 26, 2021
barcharcraz
approved these changes
Aug 30, 2021
AdamBucior
reviewed
Aug 31, 2021
StephanTLavavej
approved these changes
Sep 3, 2021
StephanTLavavej
approved these changes
Sep 3, 2021
Member
|
I'm mirroring this to the MSVC-internal repo now. Please notify me if any further changes are pushed. |
Member
|
Thanks for fixing this bug affecting my favorite floating-point notation! 🐞 🐛 ✔️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were not properly setting the
_Exponent_startvariable so that we would append trailing zeroes after the exponentThere is some refactoring, so that the handling of trailing zeros is centralized in a single switch. Also we were needlessly overwriting
_Buffer_startwhich confused me endlesslyFixes #2156