Skip to content

<iostream>: clog shouldn't be tied to cout#2056

Merged
StephanTLavavej merged 5 commits into
microsoft:mainfrom
fsb4000:fix1850
Jul 30, 2021
Merged

<iostream>: clog shouldn't be tied to cout#2056
StephanTLavavej merged 5 commits into
microsoft:mainfrom
fsb4000:fix1850

Conversation

@fsb4000
Copy link
Copy Markdown
Contributor

@fsb4000 fsb4000 commented Jul 11, 2021

Fixes #1850

I also checked godbolt: https://gcc.godbolt.org/z/68xGab4WT

libstdc++ and libc++ do not tie clog to cout.

@fsb4000 fsb4000 requested a review from a team as a code owner July 11, 2021 16:13
@fsb4000 fsb4000 changed the title clog shouldn't be tied to cout <iostream>: clog shouldn't be tied to cout Jul 11, 2021
@fsb4000 fsb4000 changed the title <iostream>: clog shouldn't be tied to cout <iostream>: clog shouldn't be tied to cout Jul 11, 2021
@fsb4000 fsb4000 changed the title <iostream>: clog shouldn't be tied to cout <iostream>: clog shouldn't be tied to cout Jul 11, 2021
@StephanTLavavej StephanTLavavej added the bug Something isn't working label Jul 13, 2021
Copy link
Copy Markdown
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I'm a little nervous about behavioral changes in iostreams, but the Standardese seems clear and other implementations confirm this.

@StephanTLavavej StephanTLavavej self-assigned this Jul 29, 2021
@StephanTLavavej
Copy link
Copy Markdown
Member

I'm going to add this to the next batch of changes to merge - please notify me if any further commits are pushed.

@CaseyCarter CaseyCarter removed their assignment Jul 29, 2021
@StephanTLavavej StephanTLavavej merged commit 1e28a23 into microsoft:main Jul 30, 2021
@StephanTLavavej
Copy link
Copy Markdown
Member

Thanks for tying up this loose end! 😹 🧵 🎉

@fsb4000 fsb4000 deleted the fix1850 branch July 30, 2021 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

<iostream>: clog tied to cout

3 participants