Implement P0401R6 Providing Size Feedback In The Allocator Interface#2036
Merged
Conversation
miscco
reviewed
Jul 2, 2021
Contributor
miscco
left a comment
miscco
left a comment
There was a problem hiding this comment.
Overall this already looks good. There are some issues though:
- We need more test coverage for exotic / strange allocators
- We are missing the feature test macro
__cpp_lib_allocate_at_leastand the corresponding tests
mnatsuhara
approved these changes
Jul 27, 2021
Contributor
mnatsuhara
left a comment
mnatsuhara
left a comment
There was a problem hiding this comment.
Looking good! Thanks for implementing this C++23 feature 😸
Member
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
Looks great, I'll push trivial comment/header changes.
StephanTLavavej
approved these changes
Jul 28, 2021
Member
|
FYI @mnatsuhara, I pushed trivial changes after you approved. |
Member
|
Thanks for implementing another C++23 feature! This will ship in VS 2022 17.0 Preview 4. 🎉 😺 😻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1969.