update the feature-test macro for P2162R2 for variant#2006
Merged
Conversation
Contributor
|
You need to also update the feature test macro test. |
Contributor
|
Come to think of it. Considering this was implemented in C++17, thus available in that mode, shouldn't the value just be updated instead of under |
Contributor
Author
|
Yes. I found it when inspected failed test: "std/language.support/support.limits/support.limits.general/variant.version.pass.cpp" |
…eneral/variant.version.pass.cpp
Contributor
|
Do we have test coverage for that to ensure we never accidentally degrade it? |
CaseyCarter
suggested changes
Jun 21, 2021
Co-authored-by: Casey Carter <[email protected]>
CaseyCarter
approved these changes
Jun 22, 2021
Member
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
Looks good! I'll push a couple of trivial test changes for style/comment issues I noticed.
StephanTLavavej
approved these changes
Jun 23, 2021
CaseyCarter
approved these changes
Jun 23, 2021
Member
|
Thanks for looking into this and adding test coverage - one step closer to C++23 completeness! 🎉 😸 ✔️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1683