Remove XP (and Server 2003) support from STL#1194
Merged
StephanTLavavej merged 21 commits intomicrosoft:masterfrom Sep 25, 2020
Merged
Remove XP (and Server 2003) support from STL#1194StephanTLavavej merged 21 commits intomicrosoft:masterfrom
StephanTLavavej merged 21 commits intomicrosoft:masterfrom
Conversation
AlexGuteniev
commented
Aug 14, 2020
StephanTLavavej
requested changes
Aug 14, 2020
Contributor
Author
|
Actually probably need to keep not only |
Contributor
Author
|
I'll only remove functions in anonymous namespace, others cannot be safely removed. |
BillyONeal
approved these changes
Aug 25, 2020
# Conflicts: # stl/src/awint.hpp # stl/src/filesystem.cpp # stl/src/winapinls.cpp # stl/src/winapisupp.cpp
# Conflicts: # stl/src/taskscheduler.cpp
Merged
Consolidate stl_MEOW_concrt comments.
Previously needed for __crtInitOnceExecuteOnce.
Member
StephanTLavavej
left a comment
There was a problem hiding this comment.
This looks good, thanks for working on this extensive set of changes! I'll push fixes for ABI compat and a few other things.
Member
|
Awesome - your PR shrinks the STL's main DLL by 1%! This is an extremely rare gift, thank you! 🎉 Changelog for the commits I pushed:
|
StephanTLavavej
approved these changes
Sep 24, 2020
Member
|
I believe I've successfully ported your |
Member
|
Thanks again for this wonderful improvement - ripping out unnecessary complicated code is so awesome. 😸 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1192