Avoid calling size() in empty() member functions (#1836)

N-Dekker · web-flow · commit b95ba0ef2f01 · 2021-04-30T17:28:23.000-07:00
diff --git a/stl/inc/vector b/stl/inc/vector
@@ -2798,7 +2798,7 @@ public:
     }
 
     _NODISCARD _CONSTEXPR20_CONTAINER bool empty() const noexcept {
-        return size() == 0;
+        return this->_Mysize == 0;
     }
 
     _NODISCARD _CONSTEXPR20_CONTAINER allocator_type get_allocator() const noexcept {
diff --git a/stl/inc/xstring b/stl/inc/xstring
@@ -4016,7 +4016,7 @@ public:
 #endif // _HAS_CXX20
 
     _NODISCARD _CONSTEXPR20_CONTAINER bool empty() const noexcept {
-        return size() == 0;
+        return _Mypair._Myval2._Mysize == 0;
     }
 
     _CONSTEXPR20_CONTAINER size_type copy(
diff --git a/stl/inc/xtree b/stl/inc/xtree
@@ -1216,7 +1216,7 @@ public:
     }
 
     _NODISCARD bool empty() const noexcept {
-        return size() == 0;
+        return _Get_scary()->_Mysize == 0;
     }
 
     _NODISCARD allocator_type get_allocator() const noexcept {

Original file line number	Diff line number	Diff line change
`@@ -2798,7 +2798,7 @@ public:`
`2798`	`2798`	`}`
`2799`	`2799`
`2800`	`2800`	`_NODISCARD _CONSTEXPR20_CONTAINER bool empty() const noexcept {`
`2801`		`- return size() == 0;`
	`2801`	`+ return this->_Mysize == 0;`
`2802`	`2802`	`}`
`2803`	`2803`
`2804`	`2804`	`_NODISCARD _CONSTEXPR20_CONTAINER allocator_type get_allocator() const noexcept {`
Original file line number	Diff line number	Diff line change
`@@ -4016,7 +4016,7 @@ public:`
`4016`	`4016`	`#endif // _HAS_CXX20`
`4017`	`4017`
`4018`	`4018`	`_NODISCARD _CONSTEXPR20_CONTAINER bool empty() const noexcept {`
`4019`		`- return size() == 0;`
	`4019`	`+ return _Mypair._Myval2._Mysize == 0;`
`4020`	`4020`	`}`
`4021`	`4021`
`4022`	`4022`	`_CONSTEXPR20_CONTAINER size_type copy(`
Original file line number	Diff line number	Diff line change
`@@ -1216,7 +1216,7 @@ public:`
`1216`	`1216`	`}`
`1217`	`1217`
`1218`	`1218`	`_NODISCARD bool empty() const noexcept {`
`1219`		`- return size() == 0;`
	`1219`	`+ return _Get_scary()->_Mysize == 0;`
`1220`	`1220`	`}`
`1221`	`1221`
`1222`	`1222`	`_NODISCARD allocator_type get_allocator() const noexcept {`