fix: Respond to issue #546#552
Conversation
Unfortunately not tested. Should fix microsoft#546
jenshnielsen
left a comment
There was a problem hiding this comment.
Looks good to me but lets wait for real testing if possible
|
@WilliamHPNielsen I dont think your mode 1 will work, you need to send fine channel data if you want to use it. |
Remove the high res mode
|
@MerlinSmiles That is a good point. I removed the fine mode. |
|
Looks good. Haven't tested but can next time I'm measuring. Considering that (thanks to @MerlinSmiles) I made almost identical changes locally i can't see it not working. |
|
I think so. Seems like when it's ready to merge #568 will replace most of this driver though. |
|
LGTM but cant test |
|
@WilliamHPNielsen will merge and see if we get more errors. |
Unfortunately not tested.
Should fix #546
@jenshnielsen @nataliejpg @MerlinSmiles