Skip to content

Comments

fix: Respond to issue #546#552

Merged
giulioungaretti merged 5 commits intomicrosoft:masterfrom
WilliamHPNielsen:hotfix/Decadac
May 8, 2017
Merged

fix: Respond to issue #546#552
giulioungaretti merged 5 commits intomicrosoft:masterfrom
WilliamHPNielsen:hotfix/Decadac

Conversation

@WilliamHPNielsen
Copy link
Contributor

Unfortunately not tested.

Should fix #546

@jenshnielsen @nataliejpg @MerlinSmiles

Unfortunately not tested.

Should fix microsoft#546
Copy link
Collaborator

@jenshnielsen jenshnielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but lets wait for real testing if possible

@MerlinSmiles
Copy link
Contributor

@WilliamHPNielsen I dont think your mode 1 will work, you need to send fine channel data if you want to use it.
I suggest to either remove mode 1, or handle the fine channel stuff.
https://github.com/qdev-dk/matlab-qd/blob/master/%2Bqd/%2Bins/HRDecaDACChannel.m

Remove the high res mode
@WilliamHPNielsen
Copy link
Contributor Author

@MerlinSmiles That is a good point. I removed the fine mode.

@nataliejpg
Copy link
Contributor

Looks good. Haven't tested but can next time I'm measuring. Considering that (thanks to @MerlinSmiles) I made almost identical changes locally i can't see it not working.

@giulioungaretti
Copy link
Contributor

@nataliejpg
Copy link
Contributor

I think so. Seems like when it's ready to merge #568 will replace most of this driver though.

@MerlinSmiles
Copy link
Contributor

LGTM but cant test

@giulioungaretti
Copy link
Contributor

@WilliamHPNielsen will merge and see if we get more errors.

@giulioungaretti giulioungaretti self-assigned this May 8, 2017
@giulioungaretti giulioungaretti merged commit b8c0065 into microsoft:master May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: decadac getting and setting voltages fails unpredictably

5 participants