ZI: clear history when reusing scope#547
Merged
WilliamHPNielsen merged 2 commits intomicrosoft:masterfrom Mar 30, 2017
Merged
Conversation
WilliamHPNielsen
approved these changes
Mar 30, 2017
Contributor
WilliamHPNielsen
left a comment
WilliamHPNielsen
left a comment
There was a problem hiding this comment.
Where is the need to clear history documented?
giulioungaretti
pushed a commit
that referenced
this pull request
Mar 30, 2017
Merge: a957e51 45c389f Author: William H.P. Nielsen <[email protected]> Merge pull request #547 from jenshnielsen/zi_clear_history
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue with changing number of segments seems to be that old data may be returned along with the new data. Clear data to ensure that this can not happen.