Merged
Conversation
Make it possible to not query the currents on startup. Also, do NOT set the voltage range during init, since this could cause voltages to jump.
Make channels be always bound to a unique function generator.
giulioungaretti
previously requested changes
Mar 21, 2017
| slope = [sl[1] for sl in self._slopes if sl[0]==chan][0] | ||
| fg = self._slopes.index([chan, slope]) + 1 | ||
| slope = [sl[1] for sl in self._slopes if sl[0] == chan][0] | ||
| # fg = self._slopes.index([chan, slope]) + 1 |
Contributor
There was a problem hiding this comment.
remove comment or comment comment <3
Add a unit to voltage ramp slope.
jenshnielsen
approved these changes
Mar 22, 2017
giulioungaretti
pushed a commit
that referenced
this pull request
Mar 22, 2017
Merge: 628fe73 4f4353b Author: William H.P. Nielsen <[email protected]> Merge pull request #533 from WilliamHPNielsen/driver/QDac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes wrong function generator assignment
@giulioungaretti