fix: make sync a no-opt on local data#421
Merged
giulioungaretti merged 7 commits intomicrosoft:masterfrom Jan 17, 2017
Merged
Conversation
fixes #380 by avoiding to overwrite data with partial data from disk
Collaborator
Author
|
This breaks
|
Contributor
Does that mean your small change there will make background loops with the current multiprocessing stuff totally impossible? |
Collaborator
Author
|
This change makes it impossible to read the data into the main process using |
So need to change the default in this test
Will no longer work so update the relevant test
Collaborator
Author
|
Test added |
giulioungaretti
approved these changes
Jan 17, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #380 by avoiding to overwrite data
with partial data from disk
Changes proposed in this pull request:
I don't think that sync has any function in local mode but if that is too intrusive jenshnielsen@fd2b0d3 is a less intrusive fix
@giulioungaretti @nataliejpg