Skip to content

Comments

fix: make sync a no-opt on local data#421

Merged
giulioungaretti merged 7 commits intomicrosoft:masterfrom
jenshnielsen:sync_fixes_2
Jan 17, 2017
Merged

fix: make sync a no-opt on local data#421
giulioungaretti merged 7 commits intomicrosoft:masterfrom
jenshnielsen:sync_fixes_2

Conversation

@jenshnielsen
Copy link
Collaborator

fixes #380 by avoiding to overwrite data
with partial data from disk

Changes proposed in this pull request:

  • Make sync a no opt in local mode rather than read data from disc

I don't think that sync has any function in local mode but if that is too intrusive jenshnielsen@fd2b0d3 is a less intrusive fix

@giulioungaretti @nataliejpg

fixes #380 by avoiding to overwrite data
with partial data from disk
@jenshnielsen
Copy link
Collaborator Author

This breaks test_local_instrument because it assumes that you can:

  • run experiment in background process
  • end background process
  • sync data over to main process

@MerlinSmiles
Copy link
Contributor

MerlinSmiles commented Dec 19, 2016

@jenshnielsen

...
run experiment in background process

Does that mean your small change there will make background loops with the current multiprocessing stuff totally impossible?

@jenshnielsen
Copy link
Collaborator Author

This change makes it impossible to read the data into the main process using sync. This is probably not the right fix but the current code is fairly convoluted. It's probably better to prevent plot.update from calling sync on default

@jenshnielsen
Copy link
Collaborator Author

Test added

@giulioungaretti giulioungaretti merged commit 52b0f4b into microsoft:master Jan 17, 2017
@jenshnielsen jenshnielsen deleted the sync_fixes_2 branch January 17, 2017 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Matplotlib can't handle more than 499 data points

3 participants