Feature/qt plot by MerlinSmiles · Pull Request #290 · microsoft/Qcodes

MerlinSmiles · 2016-07-29T17:59:06Z

Fixes the Qt part of #266
Fixes #259 I think
Fixes the Qt part of #217
Fixes #34 since setGeometry is now directly available and _repr_png_ exists
Fixes #289 I implemented it here too...

Changes proposed in this pull request:

Use pyqtgraph Docks for subplots
Expose some of the Dock-functionality to QtPlot.add()
Add transpose argument to QtPlot.add() (flip x, y axes, and transpose z)
Fix plotting when x, y, z datasets are defined
Remove Javascript update widget which is only used for update timing, replaced with native Qt timer
Add PNG representation of the plot windows
Add plotting tutorial
Add get default array title currently the location and array_id, maybe it should be reduced to the name and array_id, in the case where name exists. however, location is nice to later relate screenshots to the right dataset.
Add get_units
renamped update to update_data in base.py so it wont interfere with update() from the Qwidget
removed pyqtgraph remote plotting stuff

I'm leaving for a holiday now, but it would be great if someone could check this over, and give some input

This PR is mostly meant to fix some of the urgent issues I came across, there is still a lot to do but for that we need to refactor the whole plotting system, which seems somewhat complicated right now. Make it more modular and allow for easy additions...

@giulioungaretti @alexcjohnson @AdriaanRol @peendebak @nataliejpg

qcodes-bot · 2016-07-29T18:03:42Z

Current coverage is 88.00% (diff: 100%)

No coverage report found for master at e76f95b.

Powered by Codecov. Last update e76f95b...b428c98

MerlinSmiles · 2016-07-29T18:46:13Z

I forgot to mention that this plot is now a QtWidget, which allows to integrate it in other qt guis easily...

This reverts commit 6a73916.

eendebakpt · 2016-07-29T22:45:47Z

Just tested the PR and it works fine on my system. I took the liberty of adding part of my own additions to QtPlot: copying a figure to the system clipboard.

MerlinSmiles · 2016-07-29T22:48:34Z

Great idea, what system are you using?
If I remember right I had problems with this clipboard stuff on windows, when the window was in the background...
Also for the naming maybe copy_to_clipboard would fit better? I have the feeling we should stick to qcodes style even though Qt does the other thing.

eendebakpt · 2016-07-29T22:58:55Z

Some minor issues:

We might want to use qtpy (https://pypi.python.org/pypi/QtPy) to select the Qt interface. PyQt4 is pretty standard, but people also use PySide or PyQt5
Going from windowTitle to windowtitle makes the PR not backwards compatible. I just searched for a style-guide on function arguments in qcodes, but could not find it. One of the other arguments is show_window. I suggest we either use (showwindow, windowtitle) or (show_window, window_title), but no other combination

MerlinSmiles · 2016-07-29T23:02:52Z

Good points!
yes I was struggling with those argument names, its really annoying if one package uses one style and another one another style, and if it basically just passes through... and then I just get it messed up.

As for QtPy, I never tried it, but it might be a good idea. I remember though having problems with PySide, and PyQtgraph wont work with PyQt5 I think. But yes, that shouldnt stop us from doing it right.

eendebakpt · 2016-07-29T23:03:21Z

System is ubuntu 16.04, but our measurement system is windows, so we'll need that one as well (I can test next week). I agree using qcodes style is the right thing to do.

MerlinSmiles · 2016-07-29T23:03:54Z

And thanks for testing this!

CJvanDiepen · 2016-08-09T12:27:23Z

@MerlinSmiles The dockarea .clear() function is not in 0.9.10 (the default installed by anaconda)
This gives an error when runnin the QtPlot.clear().

The commit for pyqtgraph is here:

pyqtgraph/pyqtgraph@76dbdaf

CJvanDiepen · 2016-08-09T12:30:42Z

Also Dock.setTitle was only added later:

pyqtgraph/pyqtgraph@138fbb7

To solve the issues one can install a more recent version of pyqtgraph:

conda install -c nmearl pyqtgraph=0.9.11

eendebakpt · 2016-08-15T14:28:48Z

Deze regel: https://github.com/qdev-dk/Qcodes/pull/290/files#diff-4e71a3e969fcdacead1806f2d8a6afd7R140
is denk ik enkel python 3.5. Zie http://legacy.python.org/dev/peps/pep-0448/

lgnjanssen · 2016-08-15T14:59:46Z

@eendebakpt I can confirm. This solved it for me in python 3.4.5
geometry_settings = itertools.chain(figposition,figsize)
self.setGeometry(*geometry_settings)

giulioungaretti · 2016-09-23T13:43:35Z

@MerlinSmiles 🍻 +review ?

peendebak · 2016-10-14T11:40:29Z

@giulioungaretti @MerlinSmiles Any news on this PR?

giulioungaretti · 2016-10-28T11:26:25Z

qcodes/plots/base.py

+        '''
+        Get the default title for a data_array, which is used as the subplot
+        title. It is just the DataSet location and the array_id.
+        A custom title can be passed using **kwargs.


@MerlinSmiles kwargs? Am I missing something?

giulioungaretti · 2016-10-28T14:14:06Z

@MerlinSmiles which version of py qt graph are you using ? the last release is 0.9.10

giulioungaretti · 2016-10-28T14:17:18Z

actually, let's all wait until pyqtgraph/pyqtgraph#377 is closed and v 0.10.0 is released !

WilliamHPNielsen · 2017-02-20T12:41:27Z

I am closing this PR and deleting the branch after testimonies from Giulio and Merlin that this is nukeable.

Merlin added 2 commits July 29, 2016 19:54

feat: fix: refactor: docs: changed a lot in the QtPlot stuff

20f97a9

add: tutorial for QtPlot

d8b0375

eendebakpt added 3 commits July 30, 2016 00:31

add function to copy figure to clipboard

dc0f191

add keyboard callback for copying figure to clipboard

6a73916

Revert "add keyboard callback for copying figure to clipboard"

de462b8

This reverts commit 6a73916.

peendebak mentioned this pull request Aug 3, 2016

Qtplot/fixwarning #289

Closed

This was referenced Aug 31, 2016

Ag liveplot #315

Merged

show_subprocess_widget causes problems outside the notebook #316

Closed

giulioungaretti mentioned this pull request Sep 23, 2016

Config System #341

Closed

giulioungaretti added enhancement p2 GUI labels Sep 23, 2016

giulioungaretti mentioned this pull request Oct 25, 2016

Use config in GUI selection #364

Closed

Merge branch 'master' into feature/QtPlot

1559c19

giulioungaretti added this to the v0.1.2 milestone Oct 27, 2016

giulioungaretti mentioned this pull request Oct 27, 2016

make plot updates work outside ipython notebook #155

Closed

giulioungaretti added the Qt Related to Qt-based features label Oct 27, 2016

giulioungaretti suggested changes Oct 28, 2016

View reviewed changes

giulioungaretti self-assigned this Oct 31, 2016

giulioungaretti mentioned this pull request Nov 4, 2016

Refactor QT #381

Open

giulioungaretti and others added 3 commits November 7, 2016 09:53

Merge branch 'master' into feature/QtPlot

ee63127

fix: First pass at qt5/qtpy

3fd84c8

fix: remove obsolete qt4

acb856b

giulioungaretti closed this Nov 10, 2016

giulioungaretti deleted the feature/QtPlot branch November 10, 2016 12:31

giulioungaretti restored the feature/QtPlot branch November 10, 2016 13:44

giulioungaretti reopened this Nov 10, 2016

peendebak mentioned this pull request Nov 12, 2016

qcodes does not work with qt5 #317

Closed

MerlinSmiles mentioned this pull request Nov 15, 2016

Feature/qt_plot_2 #387

Closed

giulioungaretti modified the milestones: v0.1.2, v.0.1.3 Nov 21, 2016

WilliamHPNielsen closed this Feb 20, 2017

WilliamHPNielsen deleted the feature/QtPlot branch February 20, 2017 12:41

Comments

Conversation

MerlinSmiles commented Jul 29, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qcodes-bot commented Jul 29, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current coverage is 88.00% (diff: 100%)

Uh oh!

MerlinSmiles commented Jul 29, 2016

Uh oh!

eendebakpt commented Jul 29, 2016

Uh oh!

MerlinSmiles commented Jul 29, 2016

Uh oh!

eendebakpt commented Jul 29, 2016

Uh oh!

MerlinSmiles commented Jul 29, 2016

Uh oh!

eendebakpt commented Jul 29, 2016

Uh oh!

MerlinSmiles commented Jul 29, 2016

Uh oh!

CJvanDiepen commented Aug 9, 2016

Uh oh!

CJvanDiepen commented Aug 9, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eendebakpt commented Aug 15, 2016

Uh oh!

lgnjanssen commented Aug 15, 2016

Uh oh!

giulioungaretti commented Sep 23, 2016

Uh oh!

peendebak commented Oct 14, 2016

Uh oh!

giulioungaretti Oct 28, 2016

Choose a reason for hiding this comment

Uh oh!

giulioungaretti commented Oct 28, 2016

Uh oh!

giulioungaretti commented Oct 28, 2016

Uh oh!

WilliamHPNielsen commented Feb 20, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

MerlinSmiles commented Jul 29, 2016 •

edited

Loading

qcodes-bot commented Jul 29, 2016 •

edited

Loading

CJvanDiepen commented Aug 9, 2016 •

edited

Loading