Keithley2400 driver by ThomasKanne · Pull Request #235 · microsoft/Qcodes

ThomasKanne · 2016-06-11T22:44:12Z

Changes proposed in this pull request:

Made a Keithley driver for the 2400 model

@giulioungaretti @alexcjohnson @MerlinSmiles

MerlinSmiles · 2016-06-11T23:04:24Z

qcodes/instrument_drivers/tektronix/Keithley_2400.py

+        self.add_parameter('resistance',
+                           get_cmd=':READ?',
+                           get_parser=self._resistance_parser, 
+                           label='Voltage',


This label is probably not correct?
And the units neither?

qcodes-bot · 2016-07-11T08:56:57Z

Here is an overview of what got changed by this pull request:

Issues
======
- Added 8


Complexity increasing per file
==============================
- qcodes/instrument_drivers/tektronix/Keithley_2400.py  3

See the complete overview on Codacy

qcodes-bot · 2016-07-11T08:56:57Z

qcodes/instrument_drivers/tektronix/Keithley_2400.py

+        MerlinSmiler = [float(x) for x in msg.split(',')]
+        return MerlinSmiler[0]
+
+    def _curr_parser(self, msg):


Issue found: Method could be a function

qcodes-bot · 2016-07-28T08:56:17Z

Here is an overview of what got changed by this pull request:

Issues
======
- Added 8


Complexity increasing per file
==============================
- qcodes/instrument_drivers/tektronix/Keithley_2400.py  3

See the complete overview on Codacy

qcodes-bot · 2016-09-22T09:40:41Z

qcodes/instrument_drivers/tektronix/Keithley_2400.py

+    def reset(self):
+        self.write(':*RST')
+
+    def _volt_parser(self, msg):


Issue found: Method could be a function

qcodes-bot · 2016-09-22T09:40:41Z

qcodes/instrument_drivers/tektronix/Keithley_2400.py

+                           label='Voltage',
+                           units='V')
+
+        self.add_parameter('curr', 


Issue found: Trailing whitespace

qcodes-bot · 2016-09-22T09:40:41Z

qcodes/instrument_drivers/tektronix/Keithley_2400.py

+
+        self.add_parameter('volt',
+                           get_cmd=':READ?',
+                           get_parser=self._volt_parser, 


Issue found: Trailing whitespace

qcodes-bot · 2016-09-22T09:40:42Z

qcodes/instrument_drivers/tektronix/Keithley_2400.py

+        MerlinSmiler = [float(x) for x in msg.split(',')]
+        return MerlinSmiler[0]
+
+    def _curr_parser(self, msg):


Issue found: Method could be a function

qcodes-bot · 2016-09-22T09:40:42Z

qcodes/instrument_drivers/tektronix/Keithley_2400.py

+        MerlinSmilerIkke = [float(x) for x in msg.split(',')]
+        return MerlinSmilerIkke[1]
+
+    def _resistance_parser(self, msg):


Issue found: Method could be a function

qcodes-bot · 2016-09-22T09:40:42Z

qcodes/instrument_drivers/tektronix/Keithley_2400.py

+
+        self.add_parameter('resistance',
+                           get_cmd=':READ?',
+                           get_parser=self._resistance_parser, 


Issue found: Trailing whitespace

qcodes-bot · 2016-09-22T09:40:42Z

qcodes/instrument_drivers/tektronix/Keithley_2400.py

+        else:
+            raise AttributeError('Mode does not exist')
+        self.write(':SOUR:FUNC {:s}'.format(msg))
+


Issue found: Trailing whitespace

qcodes-bot · 2016-09-22T09:40:42Z

qcodes/instrument_drivers/tektronix/Keithley_2400.py

+
+        self.add_parameter('curr', 
+                           get_cmd=':READ?',
+                           get_parser=self._curr_parser, 


Issue found: Trailing whitespace

qcodes-bot · 2016-09-22T09:40:43Z

Here is an overview of what got changed by this pull request:

Issues
======
- Added 8


Complexity increasing per file
==============================
- qcodes/instrument_drivers/tektronix/Keithley_2400.py  3

See the complete overview on Codacy

This is a clean-up of PR microsoft#235. I suspect buggy behaviour but have not tested the driver.

WilliamHPNielsen · 2017-02-10T12:59:48Z

This is now superseded by PR #488

I'm closing this PR and deleting the branch.

clean-up of PR #235. I suspect buggy behaviour but have not tested the driver.

ThomasKanne added 2 commits June 12, 2016 00:39

Keithley2400 driver

4d9f318

fix: pep8

0007d07

ThomasKanne added the enhancement label Jun 11, 2016

MerlinSmiles reviewed Jun 11, 2016
View reviewed changes

qcodes-bot reviewed Jul 11, 2016
View reviewed changes

qcodes-bot reviewed Sep 22, 2016

View reviewed changes

WilliamHPNielsen added a commit to WilliamHPNielsen/Qcodes that referenced this pull request Feb 10, 2017

feat: Add basic driver for Keithley 2400

88a99dd

This is a clean-up of PR microsoft#235. I suspect buggy behaviour but have not tested the driver.

WilliamHPNielsen mentioned this pull request Feb 10, 2017

feat: Add basic driver for Keithley 2400 #488

Merged

WilliamHPNielsen closed this Feb 10, 2017

WilliamHPNielsen deleted the Keithley2400-driver branch February 10, 2017 13:00

giulioungaretti pushed a commit that referenced this pull request Mar 9, 2017

feat: Add basic driver for Keithley 2400 (#488)

0e3ad1b

clean-up of PR #235. I suspect buggy behaviour but have not tested the driver.

Comments

Conversation

ThomasKanne commented Jun 11, 2016

Uh oh!

MerlinSmiles Jun 11, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

qcodes-bot commented Jul 11, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

qcodes-bot commented Jul 28, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

qcodes-bot commented Sep 22, 2016

Uh oh!

WilliamHPNielsen commented Feb 10, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

MerlinSmiles Jun 11, 2016 •

edited

Loading