BugReport: Fix incorrect XML closing tag syntax generated by XmlDocumentEx #42399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `XmlDocumentEx::Print` method previously used `<\\` to close XML tags, which is invalid. This commit replaces `<\\` with `</` to ensure proper XML closing tag syntax. Changes include: - Replacing `<\\` with `</` in three instances where closing tags are generated. - Ensuring the XML output conforms to standard XML syntax. These changes improve the correctness of the XML output generated by the method.
Collaborator
Author
|
One interesting point: the XML generated for event viewer entries isn't valid XML but rather a collection of XML fragments. It might not matter much to most people, but it's still worth noting when discussing this. |
zadjii-msft
approved these changes
Oct 16, 2025
zadjii-msft
added
Hot Fix
khmyznikov
pushed a commit
that referenced
this pull request
Oct 20, 2025
…entEx (#42399) ## Summary of the Pull Request The `XmlDocumentEx::Print` method previously used `<\\` to close XML tags, which is invalid. This commit replaces `<\\` with `</` to ensure proper XML closing tag syntax. Changes include: - Replacing `<\\` with `</` in three instances where closing tags are generated. - Ensuring the XML output conforms to standard XML syntax. These changes improve the correctness of the XML output generated by the method. <img width="1014" height="499" alt="image" src="https://github.com/user-attachments/assets/a9ff6e47-6976-4290-a4f0-c23b0c773d61" /> <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [x] Closes: #42390 - [x] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [x] **Tests:** Added/updated and all pass - [x] **Localization:** All end-user-facing strings can be localized - [x] **Dev docs:** Added/updated - [x] **New binaries:** Added on the required places - [x] **Documentation updated:** <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed
Merged
khmyznikov
added a commit
that referenced
this pull request
Oct 21, 2025
Hotfixes #42467 #42434 #42405 #42399 --------- Co-authored-by: Jiří Polášek <[email protected]> Co-authored-by: Niels Laute <[email protected]> Co-authored-by: Jaylyn Barbee <[email protected]> Co-authored-by: Gordon Lam <[email protected]> Co-authored-by: Dustin L. Howett <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a critical bug in XML output formatting where closing tags were incorrectly using backslashes (<\) instead of forward slashes (</), resulting in malformed XML.
- Fixed three instances of incorrect XML closing tag syntax from
<\tagname>to</tagname> - Corrected closing tags for nodes without children, nodes with single text children, and nodes with nested children
- Ensures the XML output conforms to proper XML syntax standards
mirmirmirr
pushed a commit
to mirmirmirr/PowerToys
that referenced
this pull request
Nov 9, 2025
…entEx (microsoft#42399) ## Summary of the Pull Request The `XmlDocumentEx::Print` method previously used `<\\` to close XML tags, which is invalid. This commit replaces `<\\` with `</` to ensure proper XML closing tag syntax. Changes include: - Replacing `<\\` with `</` in three instances where closing tags are generated. - Ensuring the XML output conforms to standard XML syntax. These changes improve the correctness of the XML output generated by the method. <img width="1014" height="499" alt="image" src="https://github.com/user-attachments/assets/a9ff6e47-6976-4290-a4f0-c23b0c773d61" /> <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [x] Closes: microsoft#42390 - [x] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [x] **Tests:** Added/updated and all pass - [x] **Localization:** All end-user-facing strings can be localized - [x] **Dev docs:** Added/updated - [x] **New binaries:** Added on the required places - [x] **Documentation updated:** <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
The
XmlDocumentEx::Printmethod previously used<\\to close XML tags, which is invalid. This commit replaces<\\with</to ensure proper XML closing tag syntax.Changes include:
<\\with</in three instances where closing tags are generated.These changes improve the correctness of the XML output generated by the method.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed