perf(schema): optimize boolean schema deserialization

baywet · Copilot · baywet · commit fe6f5138b8fb · 2026-04-27T09:36:46.000-04:00
Add generic GetValue<T>() method to ValueNode to allow direct type access without string conversion. Update V31 and V32 schema deserializers to use GetValue<bool>() directly instead of converting to string and parsing with bool.TryParse(). This eliminates unnecessary string allocations and conversions for boolean schema values, improving performance in the deserialization hot path. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> (cherry picked from commit 7316e3f)
diff --git a/src/Microsoft.OpenApi/Reader/ParseNodes/ValueNode.cs b/src/Microsoft.OpenApi/Reader/ParseNodes/ValueNode.cs
@@ -28,6 +28,17 @@ public override string GetScalarValue()
                 ?? throw new OpenApiReaderException($"Expected a value at {Context.GetLocation()}.");
         }
 
+        /// <summary>
+        /// Attempts to get the underlying value directly as the specified type without string conversion.
+        /// </summary>
+        /// <typeparam name="T">The type to retrieve the value as.</typeparam>
+        /// <param name="value">The retrieved value if successful.</param>
+        /// <returns>True if the value was successfully converted to the specified type; otherwise, false.</returns>
+        public bool TryGetValue<T>(out T? value)
+        {
+            return _node.TryGetValue(out value);
+        }
+
         /// <summary>
         /// Create a <see cref="JsonNode"/>
         /// </summary>
diff --git a/src/Microsoft.OpenApi/Reader/V31/OpenApiSchemaDeserializer.cs b/src/Microsoft.OpenApi/Reader/V31/OpenApiSchemaDeserializer.cs
@@ -367,20 +367,16 @@ internal static partial class OpenApiV31Deserializer
     public static IOpenApiSchema LoadSchema(ParseNode node, OpenApiDocument hostDocument)
     {
         // Handle boolean schemas (true/false) for JSON Schema 2020-12 compatibility
-        if (node is ValueNode valueNode)
+        if (node is ValueNode valueNode && valueNode.TryGetValue<bool>(out var boolValue))
         {
-            var value = valueNode.GetScalarValue();
-            if (value != null && bool.TryParse(value, out var boolValue))
+            var boolSchema = new OpenApiSchema();
+            if (!boolValue)
             {
-                var boolSchema = new OpenApiSchema();
-                if (!boolValue)
-                {
-                    // false schema: represents "not valid" -> convert to "not: {}"
-                    boolSchema.Not = new OpenApiSchema();
-                }
-                // true schema: represents "always valid" -> return empty schema (default)
-                return boolSchema;
+                // false schema: represents "not valid" -> convert to "not: {}"
+                boolSchema.Not = new OpenApiSchema();
             }
+            // true schema: represents "always valid" -> return empty schema (default)
+            return boolSchema;
         }
 
         var mapNode = node.CheckMapNode(OpenApiConstants.Schema);

Original file line number	Diff line number	Diff line change
`@@ -367,20 +367,16 @@ internal static partial class OpenApiV31Deserializer`
`367`	`367`	`public static IOpenApiSchema LoadSchema(ParseNode node, OpenApiDocument hostDocument)`
`368`	`368`	`{`
`369`	`369`	`// Handle boolean schemas (true/false) for JSON Schema 2020-12 compatibility`
`370`		`- if (node is ValueNode valueNode)`
	`370`	`+ if (node is ValueNode valueNode && valueNode.TryGetValue<bool>(out var boolValue))`
`371`	`371`	`{`
`372`		`- var value = valueNode.GetScalarValue();`
`373`		`- if (value != null && bool.TryParse(value, out var boolValue))`
	`372`	`+ var boolSchema = new OpenApiSchema();`
	`373`	`+ if (!boolValue)`
`374`	`374`	`{`
`375`		`- var boolSchema = new OpenApiSchema();`
`376`		`- if (!boolValue)`
`377`		`- {`
`378`		`- // false schema: represents "not valid" -> convert to "not: {}"`
`379`		`- boolSchema.Not = new OpenApiSchema();`
`380`		`- }`
`381`		`- // true schema: represents "always valid" -> return empty schema (default)`
`382`		`- return boolSchema;`
	`375`	`+ // false schema: represents "not valid" -> convert to "not: {}"`
	`376`	`+ boolSchema.Not = new OpenApiSchema();`
`383`	`377`	`}`
	`378`	`+ // true schema: represents "always valid" -> return empty schema (default)`
	`379`	`+ return boolSchema;`
`384`	`380`	`}`
`385`	`381`
`386`	`382`	`var mapNode = node.CheckMapNode(OpenApiConstants.Schema);`