Skip to content

Fixed GetAsync method in Rest class#10797

Merged
keveleigh merged 3 commits into
microsoft:mainfrom
Proton-V:hotfix/rest-get-async
Oct 4, 2022
Merged

Fixed GetAsync method in Rest class#10797
keveleigh merged 3 commits into
microsoft:mainfrom
Proton-V:hotfix/rest-get-async

Conversation

@Proton-V

Copy link
Copy Markdown
Contributor

Changes

Overview

Fixed problem with using request in Rest.cs class

Fixes

  • ProcessRequestAsync method in Rest.cs

@Proton-V

Copy link
Copy Markdown
Contributor Author

@keveleigh
Hello. I see this warning from azure.
I think you can approve these changes and pipeline will accept branch?

@microsoft microsoft deleted a comment from azure-pipelines Bot Jul 29, 2022
@keveleigh

Copy link
Copy Markdown
Contributor

@keveleigh Hello. I see this warning from azure. I think you can approve these changes and pipeline will accept branch?

I'll pull this down and test it out today! Thanks!

@Zee2

Zee2 commented Aug 23, 2022

Copy link
Copy Markdown
Contributor

@keveleigh updates on this?

@keveleigh

Copy link
Copy Markdown
Contributor

Thanks for this fix! Worked great for me locally.
I pushed one slight change to BytesToString, as I was hitting a null ref in cases where the connection wasn't successful. This change allowed subsequent errors to surface for debugging purposes.

@keveleigh keveleigh self-assigned this Oct 4, 2022
@keveleigh keveleigh merged commit 3c09ff5 into microsoft:main Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Utilities WebRequestRest Rest.GetAsync() Causes Unity To Hang

5 participants