Skip to content

[2.8] Fix pointer profile layer mask syncing with prefabs#10592

Merged
keveleigh merged 7 commits into
microsoft:prerelease/2.8.0from
keveleigh:fix-hand-joint-chaser
May 17, 2022
Merged

[2.8] Fix pointer profile layer mask syncing with prefabs#10592
keveleigh merged 7 commits into
microsoft:prerelease/2.8.0from
keveleigh:fix-hand-joint-chaser

Conversation

@keveleigh

Copy link
Copy Markdown
Contributor

Overview

I found that the pointer profiles could go out of sync if they were reserialized without the inspector open. This change ensures that

  1. The pointer itself is the source of truth if there's any serialization present
  2. If no serialization is present in the pointer, default to either the global default (if initializing the field for the first time) or to whatever's in the profile serialization
  3. If the profile is changed through the inspector, immediately sync the result back to the prefab and save

@keveleigh keveleigh requested a review from RogPodge May 17, 2022 18:39
@keveleigh keveleigh self-assigned this May 17, 2022
@keveleigh keveleigh marked this pull request as ready for review May 17, 2022 18:39
@keveleigh

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@keveleigh keveleigh force-pushed the fix-hand-joint-chaser branch from 963e068 to a82b109 Compare May 17, 2022 18:44
@keveleigh keveleigh added this to the MRTK 2.8 milestone May 17, 2022
@RogPodge

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@keveleigh keveleigh merged commit 1eaa37a into microsoft:prerelease/2.8.0 May 17, 2022
@keveleigh keveleigh deleted the fix-hand-joint-chaser branch May 17, 2022 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants