Fixed issue where hand joint lookup would throw dictionary exceptions for visualizers#10574
Merged
Merged
Conversation
RogPodge
requested review from
david-c-kline,
julenka and
keveleigh
as code owners
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
david-c-kline
approved these changes
May 3, 2022
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This was referenced May 3, 2022
keveleigh
reviewed
May 4, 2022
|
|
||
| /// <summary> | ||
| /// Adds warnings to the nowarn line in the csc.rsp file located at the root of assets. Warning 618 and 649 are added to the nowarn line because if | ||
| /// Adds warnings to the nowarn line in the csc.rsp file located at the root of assets. Warning 414, 618 and 649 are added to the nowarn line because if |
Contributor
There was a problem hiding this comment.
Do csc files work in subdirectories? Mostly, I'm wondering if we could put these warnings specifically in the root of the Oculus Integration Package folder instead of for the entire user's project, which seems a little heavy-handed.
Contributor
|
The the visualizers are still null |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
If the event data did not contain entries for all joints, the hand visualizer would throw an exception as it does a lookup on a hand joint which doesn't exist. This PR fixes that, stabilizing Oculus Visuals for 39.0 and beyond for 2019.
Also fixes #10409