Fix build window#10571
Merged
keveleigh merged 5 commits intoMay 19, 2022
Merged
Conversation
…ct-async-request" This reverts commit cd96480.
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
keveleigh
force-pushed
the
fix-build-window-2
branch
from
ce0577f to
d333481
Compare
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
|
|
closing in favor of #10575 |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
david-c-kline
approved these changes
May 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
awaits don't appear to work (either at all or reliably) in the editor, so some changes to the Rest APIs made them unusable in the editor.This change reverts the await changes while attempting to preserve any sort of non-breaking changes. This also restores some API shape from before the
awaitPR.Connection is now successful!
There may still be a follow-up needed, as actual deploy is failing for me...could be user error, but idk
Changes