SpherePointer query optimization#10324
Merged
RogPodge merged 7 commits intoMay 16, 2022
Merged
Conversation
jonathoncobb
requested review from
CDiaz-MS,
david-c-kline and
julenka
as code owners
keveleigh
previously requested changes
Nov 17, 2021
jonathoncobb
force-pushed
the
jonathoncobb/query-caching
branch
from
8c66491 to
c61c68d
Compare
The SpherePointer performs multiple queries per frame at times and with every collider returned it performs a costly GetComponent call on the collider to retrieve the NearInteractionGrabbable component. This PR optimizes that logic by adding a LRU cache to the SpherePointer to cache the retrieved NearInteractionGrabbable component. The cache holds a user defined number of entries, and the cache is purged when the SpherePointer is destroyed. Editor mode unit tests are implemented for the new utilities class LRUCache.
jonathoncobb
force-pushed
the
jonathoncobb/query-caching
branch
from
c61c68d to
31e4bb1
Compare
RogPodge
approved these changes
May 13, 2022
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
keveleigh
suggested changes
May 16, 2022
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
keveleigh
approved these changes
May 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The SpherePointer performs multiple queries per frame at times and with every collider returned it performs a costly GetComponent call on the collider to retrieve the NearInteractionGrabbable component.
Changes
This PR optimizes that logic by adding a LRU cache to the SpherePointer to cache the retrieved NearInteractionGrabbable component. The cache holds a user defined number of entries, and the cache is purged when the SpherePointer is destroyed.
Editor mode unit tests are implemented for the new utilities class LRUCache.